Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 17:41 GMT+01:00 Ronald S. Bultje : >> My English language capabilities are not sufficient to explain "worse" >> better > > But you can decode the file before/after patch as well as with a reference > decoder and open the decoded files in a wave editor and visualize

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

Hi, On Tue, Feb 21, 2017 at 8:07 AM, Carl Eugen Hoyos wrote: > 2017-02-21 13:47 GMT+01:00 Ronald S. Bultje : > > For the rest of us, this isn't helpful. What differences are you seeing? > > I don't see a difference, I hear a difference. > [..] > My

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 13:47 GMT+01:00 Ronald S. Bultje : > For the rest of us, this isn't helpful. What differences are you seeing? I don't see a difference, I hear a difference. Since this isn't mentioned in the commit message, I was wondering if the difference is intended. My English

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

Hi, On Tue, Feb 21, 2017 at 6:22 AM, Carl Eugen Hoyos wrote: > 2017-02-21 12:21 GMT+01:00 Paul B Mahol : > > On 2/21/17, Carl Eugen Hoyos wrote: > >> 2017-02-21 12:07 GMT+01:00 Paul B Mahol : > >>> On 2/21/17, Carl

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 12:21 GMT+01:00 Paul B Mahol : > On 2/21/17, Carl Eugen Hoyos wrote: >> 2017-02-21 12:07 GMT+01:00 Paul B Mahol : >>> On 2/21/17, Carl Eugen Hoyos wrote: 2017-02-21 10:59 GMT+01:00 Paul B Mahol

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

On 2/21/17, Carl Eugen Hoyos wrote: > 2017-02-21 12:07 GMT+01:00 Paul B Mahol : >> On 2/21/17, Carl Eugen Hoyos wrote: >>> 2017-02-21 10:59 GMT+01:00 Paul B Mahol : Fixes #1849. >>> >>> The patch changes output for

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 12:07 GMT+01:00 Paul B Mahol : > On 2/21/17, Carl Eugen Hoyos wrote: >> 2017-02-21 10:59 GMT+01:00 Paul B Mahol : >>> Fixes #1849. >> >> The patch changes output for the sample from ticket #1848, is >> this intended? > > Yes.

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

On 2/21/17, Carl Eugen Hoyos wrote: > 2017-02-21 10:59 GMT+01:00 Paul B Mahol : >> Fixes #1849. > > The patch changes output for the sample from ticket #1848, is > this intended? Yes. ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

2017-02-21 10:59 GMT+01:00 Paul B Mahol : > Fixes #1849. The patch changes output for the sample from ticket #1848, is this intended? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avcodec/amrnbdec: fix handling of NO_DATA frames

Fixes #1849. Signed-off-by: Paul B Mahol --- libavcodec/amrnbdec.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/libavcodec/amrnbdec.c b/libavcodec/amrnbdec.c index ea299ac..e75df23 100644 --- a/libavcodec/amrnbdec.c +++