Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

Hi. Can I improve something here? On Fri, Mar 30, 2018 at 2:43 AM, Rostislav Pehlivanov wrote: > On 30 March 2018 at 00:12, Даниил Чередник > wrote: > > > Actually this test does not make a sense since encoder now use floating > > point math. I

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

On 30 March 2018 at 00:12, Даниил Чередник wrote: > Actually this test does not make a sense since encoder now use floating > point math. I should have noticed it before. > Both patches have been updated. Checked on arm. > > On Thu, Mar 29, 2018 at 1:52 AM, Michael

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

Actually this test does not make a sense since encoder now use floating point math. I should have noticed it before. Both patches have been updated. Checked on arm. On Thu, Mar 29, 2018 at 1:52 AM, Michael Niedermayer wrote: > On Tue, Mar 27, 2018 at 02:26:45AM +0300,

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

On Tue, Mar 27, 2018 at 02:26:45AM +0300, Даниил Чередник wrote: > Now it should be fine. Second patch has been fixed. > > On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник > wrote: > > > Hi. > > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind > >

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

Now it should be fine. Second patch has been fixed. On Mon, Mar 26, 2018 at 3:59 PM, Даниил Чередник wrote: > Hi. > Yes, I reproduced it on mac. A bit strange, I run fate with valgrind > during patch preparation, it was ok. > I will fix it, and send updated patch. > >

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

Hi. Yes, I reproduced it on mac. A bit strange, I run fate with valgrind during patch preparation, it was ok. I will fix it, and send updated patch. Thank you! On Sun, Mar 25, 2018 at 5:57 PM, Michael Niedermayer wrote: > On Sun, Mar 25, 2018 at 01:55:42PM +0300,

Re: [FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

On Sun, Mar 25, 2018 at 01:55:42PM +0300, Даниил Чередник wrote: [...] > libavcodec/dcaenc.c | 369 > -- > libavcodec/psymodel.c |1 > tests/fate/acodec.mak |4 > 3 files changed, 156 insertions(+), 218 deletions(-) >

[FFmpeg-devel] [PATCH] avcodec/dcaenc: Use aac psychoacoustic model for dcaenc

There are several reasons to replace dca psychoacoustic to common model: - dca psychoacoustic has some quality problems especially at high frequency bands - unclear implementation - aac implementation allows to use tonality measurement for future improvements - a bit faster AAC psychoacoustic