Re: [FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-23 Thread Michael Niedermayer
On Thu, Oct 22, 2015 at 11:40:41PM +0100, Tom Butterworth wrote: > fixes issue where alpha is ignored in some players > --- > libavcodec/hapenc.c | 3 +++ > 1 file changed, 3 insertions(+) applied btw, you are quite active on hapenc.c, more than 50% of the commits are from you, maybe you want

Re: [FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-23 Thread Tom Butterworth
On 23 October 2015 at 08:32, Carl Eugen Hoyos wrote: > Tom Butterworth gmail.com> writes: > > > fixes issue where alpha is ignored in some players > > Your patch looks ok to me, RGB0 should be added as an > input colour space but this can be an independent patch. > > Could you

Re: [FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-23 Thread Carl Eugen Hoyos
Tom Butterworth gmail.com> writes: > fixes issue where alpha is ignored in some players Your patch looks ok to me, RGB0 should be added as an input colour space but this can be an independent patch. Could you confirm that only Hap5 is supposed to contain transparency information? I just sent

[FFmpeg-devel] [PATCH] avcodec/hap: set bits_per_coded_sample

2015-10-22 Thread Tom Butterworth
fixes issue where alpha is ignored in some players --- libavcodec/hapenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/hapenc.c b/libavcodec/hapenc.c index 7daadce..cb5dcfa 100644 --- a/libavcodec/hapenc.c +++ b/libavcodec/hapenc.c @@ -242,16 +242,19 @@ static av_cold int