Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-11-01 Thread Valery Kot
> I think this would look nicer (and generate less code) as a table + loop > rather than an if-ladder making each fraction structure inline? > > E.g. something like >

Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-31 Thread Mark Thompson
On 12/10/18 08:14, Valery Kot wrote: > When using libx264 (GPL) encoder, sample aspect ratio gets stored on > both container and frame levels. For libopenh264 (LGPL) encoder, > aspect ratio on codec/frame level currently is ignored, which results > in weird display aspect ratio for non-square

Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-31 Thread Valery Kot
> > Apparently there are no acrive maintainers and no devs (other than me) > > using libopenh264. What can be done to have this patch accepted? > > One possibility is that you send a patch that adds yourself > as maintainer. > > Carl Eugen Patch for MAINTAINERS list submitted, as you suggested.

Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-31 Thread Carl Eugen Hoyos
2018-10-31 9:12 GMT+01:00, Valery Kot : > Yet another ping... > Apparently there are no acrive maintainers and no devs (other than me) > using libopenh264. What can be done to have this patch accepted? One possibility is that you send a patch that adds yourself as maintainer. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-31 Thread Valery Kot
Yet another ping... Apparently there are no acrive maintainers and no devs (other than me) using libopenh264. What can be done to have this patch accepted? On Wed, Oct 24, 2018 at 8:57 AM Valery Kot wrote: > > Another ping. > On Thu, Oct 18, 2018 at 10:46 AM Valery Kot wrote: > > > > A gentle

Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-24 Thread Valery Kot
Another ping. I understand that there is still (or anymore) no active maintainer for this module. Could any of the developers please take a look at this patch and push it? I really need it in FFmpeg repo! On Thu, Oct 18, 2018 at 10:46 AM Valery Kot wrote: > > A gentle ping...

Re: [FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-18 Thread Valery Kot
A gentle ping... On Fri, Oct 12, 2018 at 9:14 AM Valery Kot wrote: > > When using libx264 (GPL) encoder, sample aspect ratio gets stored on > both container and frame levels. For libopenh264 (LGPL) encoder, > aspect ratio on codec/frame level currently is ignored, which results > in weird display

[FFmpeg-devel] [PATCH] avcodec/libopenh264enc.c: Handle sample_aspect_ratio in libopenh264 encoder

2018-10-12 Thread Valery Kot
When using libx264 (GPL) encoder, sample aspect ratio gets stored on both container and frame levels. For libopenh264 (LGPL) encoder, aspect ratio on codec/frame level currently is ignored, which results in weird display aspect ratio for non-square pixels on some players. Proposed patch fixes