Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2022-04-28 Thread Mika Fischer
Hi, I think this patch, which was applied on 2021-09-12 in 19802d170a304f5853d92e01d0513b9e06897d61 and is included in n5.0 and n5.0.1 causes a regression. This is the (shortened) diff for the test decoding in the patch: diff --git a/tests/ref/fate/flcl1905

Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2021-09-12 Thread Paul B Mahol
will apply soon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2021-09-11 Thread Paul B Mahol
From: bnnm Fixes trac issue #7473. Removes encoder delay (skip samples) and writes remaining frame samples after EOF to get correct sample count. Output is now accurate vs players that use Microsoft's codecs (Windows Media Format Runtime). Tested vs encode>decode WMAv2 with MS's codecs and

Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2018-10-06 Thread Michael Niedermayer
On Sat, Oct 06, 2018 at 05:00:13PM +0200, Banana M. wrote: > > This will/would require several fate tests to be updated > > at least these apparently: > > make: *** [fate-wmav1-encode] Error 1 > > make: *** [fate-wmav2-encode] Error 1 > > make: *** [fate-flcl1905] Error 1 > > I'm not sure if I

Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2018-10-06 Thread Banana M.
> This will/would require several fate tests to be updated > at least these apparently: > make: *** [fate-wmav1-encode] Error 1 > make: *** [fate-wmav2-encode] Error 1 > make: *** [fate-flcl1905] Error 1 I'm not sure if I can and how to modify those, somebody could lend a hand? I can run the

Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2018-10-05 Thread Michael Niedermayer
On Fri, Oct 05, 2018 at 07:39:26PM +0200, bananaman...@gmail.com wrote: > From: bnnm > > Fixes trac issue #7473. > > Removes encoder delay (skip samples) and writes remaining frame samples after > EOF to get correct sample count. > > Output is now accurate vs players that use Microsoft's

[FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback

2018-10-05 Thread bananaman255
From: bnnm Fixes trac issue #7473. Removes encoder delay (skip samples) and writes remaining frame samples after EOF to get correct sample count. Output is now accurate vs players that use Microsoft's codecs (Windows Media Format Runtime). Tested vs encode>decode WMAv2 with MS's codecs and