Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-24 Thread Rostislav Pehlivanov
On Wed, 22 Aug 2018 at 17:01, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/prosumer.c | 405

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-24 Thread Paul B Mahol
Will apply. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Paul B Mahol
On 8/23/18, Carl Eugen Hoyos wrote: > 2018-08-23 14:51 GMT+02:00, Paul B Mahol : >> On 8/23/18, Carl Eugen Hoyos wrote: >>> 2018-08-23 14:29 GMT+02:00, Paul B Mahol : On 8/23/18, Carl Eugen Hoyos wrote: > 2018-08-23 11:11 GMT+02:00, Paul B Mahol : >> On 8/23/18, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Carl Eugen Hoyos
2018-08-23 14:51 GMT+02:00, Paul B Mahol : > On 8/23/18, Carl Eugen Hoyos wrote: >> 2018-08-23 14:29 GMT+02:00, Paul B Mahol : >>> On 8/23/18, Carl Eugen Hoyos wrote: 2018-08-23 11:11 GMT+02:00, Paul B Mahol : > On 8/23/18, Carl Eugen Hoyos wrote: >> 2018-08-22 21:24 GMT+02:00,

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Paul B Mahol
On 8/23/18, Carl Eugen Hoyos wrote: > 2018-08-23 14:29 GMT+02:00, Paul B Mahol : >> On 8/23/18, Carl Eugen Hoyos wrote: >>> 2018-08-23 11:11 GMT+02:00, Paul B Mahol : On 8/23/18, Carl Eugen Hoyos wrote: > 2018-08-22 21:24 GMT+02:00, Paul B Mahol : >> On 8/22/18, Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Carl Eugen Hoyos
2018-08-23 14:29 GMT+02:00, Paul B Mahol : > On 8/23/18, Carl Eugen Hoyos wrote: >> 2018-08-23 11:11 GMT+02:00, Paul B Mahol : >>> On 8/23/18, Carl Eugen Hoyos wrote: 2018-08-22 21:24 GMT+02:00, Paul B Mahol : > On 8/22/18, Carl Eugen Hoyos wrote: >> 2018-08-22 18:00 GMT+02:00,

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Paul B Mahol
On 8/23/18, Carl Eugen Hoyos wrote: > 2018-08-23 11:11 GMT+02:00, Paul B Mahol : >> On 8/23/18, Carl Eugen Hoyos wrote: >>> 2018-08-22 21:24 GMT+02:00, Paul B Mahol : On 8/22/18, Carl Eugen Hoyos wrote: > 2018-08-22 18:00 GMT+02:00, Paul B Mahol : > >> +switch

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Carl Eugen Hoyos
2018-08-23 11:11 GMT+02:00, Paul B Mahol : > On 8/23/18, Carl Eugen Hoyos wrote: >> 2018-08-22 21:24 GMT+02:00, Paul B Mahol : >>> On 8/22/18, Carl Eugen Hoyos wrote: 2018-08-22 18:00 GMT+02:00, Paul B Mahol : > +switch (avctx->bits_per_coded_sample) { > +case 12: >

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Paul B Mahol
On 8/23/18, Michael Niedermayer wrote: > On Wed, Aug 22, 2018 at 06:00:54PM +0200, Paul B Mahol wrote: >> Signed-off-by: Paul B Mahol >> --- >> libavcodec/Makefile | 1 + >> libavcodec/allcodecs.c | 1 + >> libavcodec/avcodec.h| 1 + >> libavcodec/codec_desc.c | 7 + >>

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Michael Niedermayer
On Wed, Aug 22, 2018 at 06:00:54PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/codec_desc.c | 7 + > libavcodec/prosumer.c | 405

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Paul B Mahol
On 8/23/18, Carl Eugen Hoyos wrote: > 2018-08-22 21:24 GMT+02:00, Paul B Mahol : >> On 8/22/18, Carl Eugen Hoyos wrote: >>> 2018-08-22 18:00 GMT+02:00, Paul B Mahol : >>> +switch (avctx->bits_per_coded_sample) { +case 12: + s->stride = 3LL * FFALIGN(avctx->width,

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-23 Thread Carl Eugen Hoyos
2018-08-22 21:24 GMT+02:00, Paul B Mahol : > On 8/22/18, Carl Eugen Hoyos wrote: >> 2018-08-22 18:00 GMT+02:00, Paul B Mahol : >> >>> +switch (avctx->bits_per_coded_sample) { >>> +case 12: >>> + s->stride = 3LL * FFALIGN(avctx->width, 8) >> 1; >>> + break; >>> +

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-22 Thread Paul B Mahol
On 8/22/18, Carl Eugen Hoyos wrote: > 2018-08-22 18:00 GMT+02:00, Paul B Mahol : > >> +switch (avctx->bits_per_coded_sample) { >> +case 12: >> + s->stride = 3LL * FFALIGN(avctx->width, 8) >> 1; >> + break; >> +default: >> + return AVERROR_INVALIDDATA; >> +}

Re: [FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-22 Thread Carl Eugen Hoyos
2018-08-22 18:00 GMT+02:00, Paul B Mahol : > +switch (avctx->bits_per_coded_sample) { > +case 12: > + s->stride = 3LL * FFALIGN(avctx->width, 8) >> 1; > + break; > +default: > + return AVERROR_INVALIDDATA; > +} Why are the condition and the error needed?

[FFmpeg-devel] [PATCH] avcodec: add Brooktree ProSumer Video decoder

2018-08-22 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 + libavcodec/prosumer.c | 405 libavformat/riff.c | 1 + 6 files changed, 416