Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2017-12-13 Thread Rodger Combs
> On May 9, 2016, at 08:28, Hendrik Leppkes wrote: > > On Mon, May 9, 2016 at 3:26 PM, Derek Buitenhuis > wrote: >> On 5/9/2016 2:22 PM, Paul B Mahol wrote: >>> Once st->codec is gone, how would this lossless info be gathered back? >> >> As

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-18 Thread Michael Niedermayer
On Mon, May 09, 2016 at 02:29:50PM +0200, Michael Niedermayer wrote: > On Sun, May 08, 2016 at 05:42:13PM +0200, Hendrik Leppkes wrote: > > On Sun, May 8, 2016 at 5:33 PM, Michael Niedermayer > > wrote: > > > On Sun, May 08, 2016 at 04:10:01PM +0200, wm4 wrote: > > >> On

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-16 Thread Hendrik Leppkes
On Mon, May 16, 2016 at 4:43 AM, James Almer wrote: > On 5/8/2016 12:18 PM, Hendrik Leppkes wrote: >> On Sun, May 8, 2016 at 12:10 PM, Michael Niedermayer >> wrote: >>> Fixes Ticket5467 >>> >>> Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-15 Thread James Almer
On 5/8/2016 12:18 PM, Hendrik Leppkes wrote: > On Sun, May 8, 2016 at 12:10 PM, Michael Niedermayer > wrote: >> Fixes Ticket5467 >> >> Signed-off-by: Michael Niedermayer >> --- >> libavcodec/avcodec.h |4 >> libavcodec/utils.c |2 ++

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Michael Niedermayer
On Mon, May 09, 2016 at 01:44:54PM +0100, Derek Buitenhuis wrote: > On 5/9/2016 1:29 PM, Michael Niedermayer wrote: > > Also theres a deeper problem, > > User want, benefit from and sometimes need, "every single piece of > > information a decoder might output.", well not "every" of course > > but

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread wm4
On Mon, 9 May 2016 15:28:11 +0200 Hendrik Leppkes wrote: > On Mon, May 9, 2016 at 3:26 PM, Derek Buitenhuis > wrote: > > On 5/9/2016 2:22 PM, Paul B Mahol wrote: > >> Once st->codec is gone, how would this lossless info be gathered back? > >

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 2:28 PM, Hendrik Leppkes wrote: > And before people argue that avformat does this anyway today - one of > the hopes is to make it stop doing that for many "simple" codecs where > this is just not necessary, and say a parser could extract all the > important information with much less

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Hendrik Leppkes
On Mon, May 9, 2016 at 3:26 PM, Derek Buitenhuis wrote: > On 5/9/2016 2:22 PM, Paul B Mahol wrote: >> Once st->codec is gone, how would this lossless info be gathered back? > > As myself and others have said above: decode a frame. And before people argue that avformat

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 2:22 PM, Paul B Mahol wrote: > Once st->codec is gone, how would this lossless info be gathered back? As myself and others have said above: decode a frame. It is not a demuxer's job to provide info gleaned from decoding. Either avformat should be properly separate as it (kind of) is

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Paul B Mahol
On 5/9/16, Derek Buitenhuis wrote: > On 5/9/2016 2:19 PM, Paul B Mahol wrote: >> Isn't st->codec deprecated? > > It is, but the old behavior should be maintained for the duration > of its deprecation period. It's a bug not to add it back to st->codec > in my opinion.

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 2:19 PM, Paul B Mahol wrote: > Isn't st->codec deprecated? It is, but the old behavior should be maintained for the duration of its deprecation period. It's a bug not to add it back to st->codec in my opinion. - Derek ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Paul B Mahol
On 5/9/16, Derek Buitenhuis wrote: > On 5/9/2016 1:52 PM, Carl Eugen Hoyos wrote: >> So can you answer why the codec aspect ratio is provided but >> other information is not? > > Most because e.g. some *conatiners* need this info. No containers, to my > knowledge, need

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 1:52 PM, Carl Eugen Hoyos wrote: > So can you answer why the codec aspect ratio is provided but > other information is not? Most because e.g. some *conatiners* need this info. No containers, to my knowledge, need this 'lossless' info. > Do you agree that the answer is that decoders

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 1:48 PM, Carl Eugen Hoyos wrote: > This should get applied asap imo. NAK! This patch has at least 3 people dissenting and it doesn't actually "fix" anything except cosmetic output on the console, which is NOT meant to be parsed not even stable. > Arguing that the frame should be

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Carl Eugen Hoyos
Derek Buitenhuis gmail.com> writes: > It's not reasonable to expect a *demuxer* to provide decoder info. So can you answer why the codec aspect ratio is provided but other information is not? Do you agree that the answer is that decoders need this information? Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Carl Eugen Hoyos
Michael Niedermayer niedermayer.cc> writes: > Fixes Ticket5467 This should get applied asap imo. Arguing that the frame should be decoded a second time to get the information seems like a good argument in favour of this patch. Thank you for trying to help, Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 8:36 AM, wm4 wrote: > I'd argue that AVCodecParameters should contain only container > properties, or we'd end up with duplicating most of AVCodecContext in > it. Agreed. IMO the correct solution for user applications is to decode a frame. It's not reasonable to expect a *demuxer* to

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Derek Buitenhuis
On 5/9/2016 1:29 PM, Michael Niedermayer wrote: > Also theres a deeper problem, > User want, benefit from and sometimes need, "every single piece of > information a decoder might output.", well not "every" of course > but its hard to draw lines what may be needed and what not. They can decode a

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread Michael Niedermayer
On Sun, May 08, 2016 at 05:42:13PM +0200, Hendrik Leppkes wrote: > On Sun, May 8, 2016 at 5:33 PM, Michael Niedermayer > wrote: > > On Sun, May 08, 2016 at 04:10:01PM +0200, wm4 wrote: > >> On Sun, 8 May 2016 12:10:07 +0200 > >> Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-09 Thread wm4
On Sun, 8 May 2016 17:33:32 +0200 Michael Niedermayer wrote: > On Sun, May 08, 2016 at 04:10:01PM +0200, wm4 wrote: > > On Sun, 8 May 2016 12:10:07 +0200 > > Michael Niedermayer wrote: > > > > > Fixes Ticket5467 > > > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-08 Thread Michael Niedermayer
On Sun, May 08, 2016 at 05:18:40PM +0200, Hendrik Leppkes wrote: > On Sun, May 8, 2016 at 12:10 PM, Michael Niedermayer > wrote: > > Fixes Ticket5467 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avcodec.h |4 > >

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-08 Thread Hendrik Leppkes
On Sun, May 8, 2016 at 5:33 PM, Michael Niedermayer wrote: > On Sun, May 08, 2016 at 04:10:01PM +0200, wm4 wrote: >> On Sun, 8 May 2016 12:10:07 +0200 >> Michael Niedermayer wrote: >> >> > Fixes Ticket5467 >> > >> > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-08 Thread Michael Niedermayer
On Sun, May 08, 2016 at 04:10:01PM +0200, wm4 wrote: > On Sun, 8 May 2016 12:10:07 +0200 > Michael Niedermayer wrote: > > > Fixes Ticket5467 > > > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/avcodec.h |4 > >

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-08 Thread Hendrik Leppkes
On Sun, May 8, 2016 at 12:10 PM, Michael Niedermayer wrote: > Fixes Ticket5467 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h |4 > libavcodec/utils.c |2 ++ > 2 files changed, 6 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-08 Thread wm4
On Sun, 8 May 2016 12:10:07 +0200 Michael Niedermayer wrote: > Fixes Ticket5467 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/avcodec.h |4 > libavcodec/utils.c |2 ++ > 2 files changed, 6 insertions(+) > > diff

[FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2016-05-08 Thread Michael Niedermayer
Fixes Ticket5467 Signed-off-by: Michael Niedermayer --- libavcodec/avcodec.h |4 libavcodec/utils.c |2 ++ 2 files changed, 6 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3813a0a..1db2e0f 100644 --- a/libavcodec/avcodec.h