Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 2018-03-22 16:04 +0100, Nicolas George wrote: > Paul B Mahol (2018-03-22): > > So user can pick which channels to extract. > > > > Signed-off-by: Paul B Mahol > > --- > > doc/filters.texi | 18 ++ > > libavfilter/af_channelsplit.c | 39

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-22): > So user can pick which channels to extract. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 18 ++ > libavfilter/af_channelsplit.c | 39 +-- > 2 files changed, 51

[FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

So user can pick which channels to extract. Signed-off-by: Paul B Mahol --- doc/filters.texi | 18 ++ libavfilter/af_channelsplit.c | 39 +-- 2 files changed, 51 insertions(+), 6 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Hi Paul! On 2018-03-20 19:11 +0100, Paul B Mahol wrote: > So user can pick which channels to extract. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 > libavfilter/af_channelsplit.c | 54 > +++ >

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-21): > I have legitimate technical concert about your faulty review. Seriously, have you no pride at all for the quality of your code? Personally, I would feel ashamed to publish that code, let alone defend it if somebody points the flaw to me. > There is log message which

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> It is hardly identical, and I can not read your mind. > > More than half the block is identical to the previous one. > >> And it is functionally incompatible. > > I told you how you can factor it. > >> Enough

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-21): > It is hardly identical, and I can not read your mind. More than half the block is identical to the previous one. > And it is functionally incompatible. I told you how you can factor it. > Enough bikesheds from you! This is a legitimate technical concern:

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> >> +uint64_t channel_layout; >> >> +int nb_extracted_channels; >> > Inconsistent variable names. >> I dont follow. > > The two variables describe the same entity, they should have the same > base

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-21): > >> +uint64_t channel_layout; > >> +int nb_extracted_channels; > > Inconsistent variable names. > I dont follow. The two variables describe the same entity, they should have the same base name: nb_extracted_channels and extracted_channels, obviously. >

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-20): >> So user can pick which channels to extract. >> >> Signed-off-by: Paul B Mahol >> --- >> doc/filters.texi | 15 >> libavfilter/af_channelsplit.c | 54 >>

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-20): > So user can pick which channels to extract. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 > libavfilter/af_channelsplit.c | 54 > +++ > 2 files changed, 60

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On Wed, 21 Mar 2018 16:07:32 +0100 Nicolas George wrote: > Paul B Mahol (2018-03-21): > > I can't wait. > > Sure you can. Easy: go read wikipedia, go watch youtobe, go run in the > neighbourhood, go read a book. Do you need more ideas? > > > You could instead of

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> I can't wait. > > Sure you can. Easy: go read wikipedia, go watch youtobe, go run in the > neighbourhood, go read a book. Do you need more ideas? > >> You could instead of spending time replying to

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-21): > I can't wait. Sure you can. Easy: go read wikipedia, go watch youtobe, go run in the neighbourhood, go read a book. Do you need more ideas? > You could instead of spending time replying to this mails > do review patches. Are you under the

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/21/18, Nicolas George wrote: > Paul B Mahol (2018-03-21): >> Enough hours passed, time to apply. > > Stop being ridiculous. Wait three days at least, then ping, then wait > one week more if there are no answers. I can't wait. You could instead of spending time replying to

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-21): > Enough hours passed, time to apply. Stop being ridiculous. Wait three days at least, then ping, then wait one week more if there are no answers. Regards, -- Nicolas George signature.asc Description: Digital signature

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/20/18, Paul B Mahol wrote: > On 3/20/18, Nicolas George wrote: >> Paul B Mahol (2018-03-20): >>> Please comment, comitting ASAP. >> >> Three hours? Really? >> >> Seriously, what is your rush? > > It is snowing, and electricity is near full depletion. >

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/20/18, Nicolas George wrote: > Paul B Mahol (2018-03-20): >> Please comment, comitting ASAP. > > Three hours? Really? > > Seriously, what is your rush? It is snowing, and electricity is near full depletion. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

Paul B Mahol (2018-03-20): > Please comment, comitting ASAP. Three hours? Really? Seriously, what is your rush? Regards, -- Nicolas George signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

On 3/20/18, Paul B Mahol wrote: > So user can pick which channels to extract. > > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 15 > libavfilter/af_channelsplit.c | 54 > +++ > 2

[FFmpeg-devel] [PATCH] avfilter/af_channelsplit: add channels option

So user can pick which channels to extract. Signed-off-by: Paul B Mahol --- doc/filters.texi | 15 libavfilter/af_channelsplit.c | 54 +++ 2 files changed, 60 insertions(+), 9 deletions(-) diff --git