Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

Hi, On Fri, Jan 19, 2018 at 5:03 PM, Michael Niedermayer wrote: > On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote: >> Hi, >> >> > >> > Ping. Unless text needs to be rescaled as well, this patch is ready for >> > review. >> > >> > >> > Regards, >> > Gyan >> >

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

On Fri, Jan 19, 2018 at 03:46:57PM -0800, Kyle Swanson wrote: > Hi, > > > > > Ping. Unless text needs to be rescaled as well, this patch is ready for > > review. > > > > > > Regards, > > Gyan > > ___ > > ffmpeg-devel mailing list > >

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

Hi, > > Ping. Unless text needs to be rescaled as well, this patch is ready for > review. > > > Regards, > Gyan > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel LGTM as-is. I'll push this

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

On 1/11/2018 7:12 PM, Gyan Doshi wrote: The no-op commit e496c45 from Libav introduced an option which allowed the user to relocate text to fit within the frame if it was going out of bounds. For some reason, when the merge commit b479e01 was applied, the option was added but the code

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

On 1/12/2018 2:01 PM, Kyle Swanson wrote: Just read through the patch, but actually didn't try it yet. I wonder if we should also scale the size of the text in cases where it's wider than the frame? Worth considering. Note that fontsize may be dynamic e.g. `50+t*20` which can lead to jerky

Re: [FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

Hi, On Thu, Jan 11, 2018 at 5:42 AM, Gyan Doshi wrote: > The no-op commit e496c45 from Libav introduced an option which allowed the > user to relocate text to fit within the frame if it was going out of bounds. > > For some reason, when the merge commit b479e01 was applied,

[FFmpeg-devel] [PATCH] avfilter/drawtext - implement fix_bounds

The no-op commit e496c45 from Libav introduced an option which allowed the user to relocate text to fit within the frame if it was going out of bounds. For some reason, when the merge commit b479e01 was applied, the option was added but the code fragment which implemented it, was not. So the