Paul B Mahol (2017-11-30):
> I like nano-optimizations!
If it makes the code negligibly faster at the cost of making it more
complex, it is a nano-optimization. In this case, since it makes the
code both simpler and faster, it is just better coding.
> Should I commit with that changed or send ano
On 11/30/17, Nicolas George wrote:
> Moritz Barsnick (2017-11-30):
>> Wouldn't
>>tile->first_frame = 0;
>> be faster and easier? Or did you mean to use different variables in the
>> check and the assignment?
>
> Or even clearing the option after is has been used. Single test, single
>
Moritz Barsnick (2017-11-30):
> Wouldn't
>tile->first_frame = 0;
> be faster and easier? Or did you mean to use different variables in the
> check and the assignment?
Or even clearing the option after is has been used. Single test, single
field: faster, less memory, less code.
Regards
On Wed, Nov 29, 2017 at 20:29:49 +0100, Paul B Mahol wrote:
> +{ "init_padding", " set how many frames to initially pad",
> OFFSET(init_padding),
^ space
Some whitespace slipped in there.
> +if (tile->first_frame)
> +tile->first_frame = 0;
Would
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 5 +
libavfilter/vf_tile.c | 16 +++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 4a4efc70c8..ec37b9dcb8 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -1
Paul B Mahol (2017-11-29):
> Signed-off-by: Paul B Mahol
> ---
> doc/filters.texi | 4
> libavfilter/vf_tile.c | 12 +++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 4a4efc70c8..4eb302448b 100644
> --- a/doc/f
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 4
libavfilter/vf_tile.c | 12 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 4a4efc70c8..4eb302448b 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -14637,
Paul B Mahol (2017-11-24):
> Signed-off-by: Paul B Mahol
> ---
> doc/filters.texi | 4
> libavfilter/vf_tile.c | 12 +++-
> 2 files changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 76929e4db5..11ce0482c2 100644
> --- a/doc/f
Signed-off-by: Paul B Mahol
---
doc/filters.texi | 4
libavfilter/vf_tile.c | 12 +++-
2 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/doc/filters.texi b/doc/filters.texi
index 76929e4db5..11ce0482c2 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -14497,
