Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-04 Thread Timo Rothenpieler
On 9/4/2018 3:54 PM, Moritz Barsnick wrote: On Tue, Sep 04, 2018 at 07:43:10 +, Roman Arzumanyan wrote: Hi Timo, Refactored the patch according to your review: +{ "interp_algo","Interpolation algorithm used for transposing", OFFSET(interp_algo), AV_OPT_TYPE_INT,{ .i64 =

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-04 Thread Moritz Barsnick
On Tue, Sep 04, 2018 at 07:43:10 +, Roman Arzumanyan wrote: > Hi Timo, > > Refactored the patch according to your review: > +{ "interp_algo","Interpolation algorithm used for transposing", > OFFSET(interp_algo), AV_OPT_TYPE_INT,{ .i64 = NPPI_INTER_CUBIC }, 0, > INT_MAX, FLAGS,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-04 Thread Roman Arzumanyan
eler Sent: Monday, September 3, 2018 1:43 PM To: FFmpeg development discussions and patches ; Roman Arzumanyan Cc: Yogender Gupta Subject: Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter Minus the missing configure dependency, documentation entry and minor bump,

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-03 Thread Timo Rothenpieler
I did some re-formating and added the missing configure bit. Updated patch for that can be found on Github: https://github.com/BtbN/FFmpeg/commit/3e9ad52cfbebfade0d26758dad862e0c0a002c91 https://github.com/BtbN/FFmpeg/commit/3e9ad52cfbebfade0d26758dad862e0c0a002c91.patch smime.p7s

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-09-03 Thread Timo Rothenpieler
Minus the missing configure dependency, documentation entry and minor bump, the filter looks fine to me code wise. Two issues though: From my understanding, it's not a transpose filter, but a rotation one, fixed to 90 degree angles. Unless I'm missing something in the code, it's not doing

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-08-30 Thread Michael Niedermayer
On Thu, Aug 30, 2018 at 10:13:28AM +, Roman Arzumanyan wrote: > Hello, > This patch adds NPP transpose filter. > > Cmd example: > ffmpeg.exe -hwaccel cuvid -c:v h264_cuvid -i input.mp4 -vf > transpose_npp="t=3" -c:v h264_nvenc -y output_transpose_npp.mp4 > > Supported values: > t=0 no

Re: [FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-08-30 Thread Timo Rothenpieler
Thanks! I'm a bit short on time at the moment, but I'll try to have a look during the weekend. If someone else also wants to give a review, please go ahead! smime.p7s Description: S/MIME Cryptographic Signature ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avfilter/vf_transpose adding NPP transpose filter

2018-08-30 Thread Roman Arzumanyan
Hello, This patch adds NPP transpose filter. Cmd example: ffmpeg.exe -hwaccel cuvid -c:v h264_cuvid -i input.mp4 -vf transpose_npp="t=3" -c:v h264_nvenc -y output_transpose_npp.mp4 Supported values: t=0 no transpose t=1 90 deg clockwise t=2 180 deg clockwise t=3 270 deg clockwise -- BR, Roman