Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-06 Thread Moritz Barsnick
On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: > This is not the first of your filters where you describe a parameter as > a "percentage", but expect a float value [0, 1]. That is extremely > confusing, if not even wrong. To me, a percentage covers [0, 100]. You > need to find a

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-06 Thread Ganesh Ajjanagadde
On Wed, Jan 6, 2016 at 5:36 AM, Moritz Barsnick wrote: > On Tue, Jan 05, 2016 at 21:36:20 +0100, Moritz Barsnick wrote: >> This is not the first of your filters where you describe a parameter as >> a "percentage", but expect a float value [0, 1]. That is extremely >> confusing,

[FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-05 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 86 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_ahistogram.c | 391 +++ 4 files changed, 479 insertions(+) create

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2016-01-05 Thread Moritz Barsnick
On Tue, Jan 05, 2016 at 21:19:12 +0100, Paul B Mahol wrote: > +It accepts the following values: > +@table @samp > +@item replace > +logarithmic ^^^ This description is a copy/paste error. > +@item pheight > +Set histogram percentage of window height. [...] > +{ "pheight", "set histogram

Re: [FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2015-12-30 Thread Lou Logan
On Wed, 30 Dec 2015 13:49:07 +0100, Paul B Mahol wrote: > diff --git a/doc/filters.texi b/doc/filters.texi [...] > +@item ascale > +Set amplitude scale. > + > +It accepts the following values: > +@table @samp > +@item log > +logarithmic > +@item lin > +linear > +@end table Default is

[FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2015-12-30 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 70 + libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_ahistogram.c | 358 +++ 4 files changed, 430 insertions(+) create

[FFmpeg-devel] [PATCH] avfilter: add ahistogram multimedia filter

2015-12-29 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_ahistogram.c | 235 +++ 3 files changed, 237 insertions(+) create mode 100644 libavfilter/avf_ahistogram.c diff