Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-26 Thread Richard Ling
Thanks Paul. Thanks also to all reviewers for your comments! It's very helpful to have extra sets of eyes to find my bugs. Moritz is right, there is an unused #define, I will try to find time to patch. Or maybe Paul can remove it Regards R. ___

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-24 Thread Paul B Mahol
On 11/23/17, Richard Ling wrote: > On Nov 21, 2017 10:32 PM, "Moritz Barsnick" wrote: >> >> Nice. I personally appreciate your code comments, as I'm no big filter >> author (yet). > > I've never made any contribution to ffmpeg before, so I'm almost

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-23 Thread Richard Ling
On Nov 21, 2017 10:32 PM, "Moritz Barsnick" wrote: > > Nice. I personally appreciate your code comments, as I'm no big filter > author (yet). I've never made any contribution to ffmpeg before, so I'm almost certainly a bad example to follow :-P But I do like code to be well

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-21 Thread Moritz Barsnick
On Tue, Nov 21, 2017 at 21:45:00 +1100, Richard Ling wrote: > Updated patch. Nice. I personally appreciate your code comments, as I'm no big filter author (yet). > doc/filters.texi | 80 ++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + >

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-21 Thread Richard Ling
Updated patch. The integer overflow is avoided by limiting smoothing parameter to MAX_INT/8. It is later multiplied by 6. Regards R. 0001-avfilter-add-normalize-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-20 Thread Richard Ling
Thanks Moritz. I'll update and repost a new patch. I also noticed another error of mine: I hadn't fully updated the examples in the documentation, after changes to the parameter. Regards R. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-20 Thread Moritz Barsnick
On Mon, Nov 20, 2017 at 19:01:12 +1100, Richard Ling wrote: > Patch attached. You code nicely sticks to floats throughout, but at points like these: > +min[c].smoothed = (min[c].smoothed *s->independence) > ++ (rgb_min_smoothed * (1.0 - s->independence));

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-20 Thread Richard Ling
Patch attached. R. 0001-avfilter-add-normalize-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-19 Thread Paul B Mahol
On 11/19/17, Richard Ling wrote: > OK, trying again. I've worked out how to send to myself without corruption > (I think). Still broken. Post patch as attachment. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-19 Thread Richard Ling
OK, trying again. I've worked out how to send to myself without corruption (I think). From 590b3bc8e2675c75c2ff7e75f7fc1fbb1e1a8f71 Mon Sep 17 00:00:00 2001 From: Richard Ling Date: Thu, 16 Nov 2017 23:00:01 +1100 Subject: [PATCH] avfilter: add normalize filter ---

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-18 Thread Paul B Mahol
On 11/16/17, Richard Ling wrote: > On 24 October 2017 at 07:26, Paul B Mahol wrote: >> On 9/14/17, Richard Ling wrote: >>> Hi, >>> >>> This patch adds a filter to normalize (contrast stretch) RGB video. >>> Comments welcome. >>> >>> R. >>

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-16 Thread Paul B Mahol
On 11/16/17, Carl Eugen Hoyos wrote: > 2017-11-16 13:47 GMT+01:00 Richard Ling : > >> I created a new patch based on the feedback from Nicolas, but I was >> not able to get Gmail to send it back to me without mangling it. > >> According to the answer at the

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-16 Thread Martin Vignali
Hello, > Maybe there's some other way to send a patch (base64, attached zip file, > ???) > > > https://ffmpeg.org/git-howto.html#Preparing-a-patchset try git format-patch origin/master and put in attach the file(s) Martin

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-16 Thread Carl Eugen Hoyos
2017-11-16 13:47 GMT+01:00 Richard Ling : > I created a new patch based on the feedback from Nicolas, but I was > not able to get Gmail to send it back to me without mangling it. > According to the answer at the bottom of >

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-11-16 Thread Richard Ling
On 24 October 2017 at 07:26, Paul B Mahol wrote: > On 9/14/17, Richard Ling wrote: >> Hi, >> >> This patch adds a filter to normalize (contrast stretch) RGB video. >> Comments welcome. >> >> R. > > What's status of this? I created a new patch based on the

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-10-23 Thread Paul B Mahol
On 9/14/17, Richard Ling wrote: > Hi, > > This patch adds a filter to normalize (contrast stretch) RGB video. > Comments welcome. > > R. > > From f08f132ecd79718d0ce6fb07f99c84ab5dd52ee4 Mon Sep 17 00:00:00 2001 > From: Richard Ling > Date: Thu, 14 Sep 2017

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-09-21 Thread Richard Ling
> > > Thanks for the patch. Unfortunately, your mail software mangled it with > line breaks, it cannot be applied as is. Still, see a few comments > below. > > I should have posted to myself first to make sure it worked OK. I will do that before posting another patch to the list. > +The amount of

Re: [FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-09-14 Thread Nicolas George
L'octidi 28 fructidor, an CCXXV, Richard Ling a écrit : > This patch adds a filter to normalize (contrast stretch) RGB video. > Comments welcome. Thanks for the patch. Unfortunately, your mail software mangled it with line breaks, it cannot be applied as is. Still, see a few comments below. > >

[FFmpeg-devel] [PATCH] avfilter: add normalize filter

2017-09-13 Thread Richard Ling
Hi, This patch adds a filter to normalize (contrast stretch) RGB video. Comments welcome. R. From f08f132ecd79718d0ce6fb07f99c84ab5dd52ee4 Mon Sep 17 00:00:00 2001 From: Richard Ling Date: Thu, 14 Sep 2017 13:18:50 +1000 Subject: [PATCH] avfilter: add normalize filter ---