Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-14 Thread Steven Hartland
Any thoughts on my previous reply? On Mon, 4 Jul 2022 at 23:33, Steven Hartland wrote: > I'm not sure we're on the same page, so let me try and clarify. > > The files have multiple tracks, the standard audio and video and 3 > metadata tracks. I'm using the command line option -map >

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-04 Thread Steven Hartland
I'm not sure we're on the same page, so let me try and clarify. The files have multiple tracks, the standard audio and video and 3 metadata tracks. I'm using the command line option -map 0:m:handler_name:"" to identify the tracks to copy. Given a single file this works as expected, but as soon as

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-03 Thread Nicolas George
Andreas Rheinhardt (12022-07-03): > > For example, with your change, if you concatenate a file with metadata > > "start_time=12:00" and another with "start_time=12:01", it will generate > > a file with both metadata entries instead of just the first one as would > > be desirable. > Actually, the

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-03 Thread Andreas Rheinhardt
Nicolas George: > Steven Hartland (12022-07-02): >> I'm using concat to join multiple files from a GoPro camera including the >> three metadata streams, with the early return it fails as the metadata >> stream information is missing so map fails. > >> I believe the reason for the failure is that

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-03 Thread Nicolas George
Steven Hartland (12022-07-02): > I'm using concat to join multiple files from a GoPro camera including the > three metadata streams, with the early return it fails as the metadata > stream information is missing so map fails. > I believe the reason for the failure is that this early return

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
I should mention that this one of a few fixes needed to enable successful copying of GoPro metadata when using concat to join files, but wanted to start with from its size was the simplest one :) On Sat, 2 Jul 2022 at 11:44, Steven Hartland wrote: > I'm using concat to join multiple files from

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
I'm using concat to join multiple files from a GoPro camera including the three metadata streams, with the early return it fails as the metadata stream information is missing so map fails. Example of the command line is: ffmpeg \ -y \ -safe 0 \ -f concat \ -i

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-06-19 Thread Marton Balint
On Sun, 12 Jun 2022, Steven Hartland wrote: Remove return after copying extradata as this prevents metadata being duplicated correctly. The return there originated from commit b24d6c5303720fbd59cbd25c392229450660 and seems very much intentional to not overwrite stream parameters

[FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-06-12 Thread Steven Hartland
Remove return after copying extradata as this prevents metadata being duplicated correctly. Signed-off-by: Steven Hartland --- libavformat/concatdec.c | 1 - tests/ref/fate/concat-demuxer-simple2-lavf-ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git