> 2021年8月4日 下午2:30,Nicolas George 写道:
>
> Steven Liu (12021-08-04):
>> Ok, "avformat/hls: return ret when read_packet return error codes."
>
> "forward error code" is the idiomatic wording, according to git log.
What about “Return sensible error values and forward error codes.” ?
>
>
Steven Liu (12021-08-04):
> Ok, "avformat/hls: return ret when read_packet return error codes."
"forward error code" is the idiomatic wording, according to git log.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
> 2021年8月4日 下午2:18,Nicolas George 写道:
>
> Steven Liu (12021-08-04):
>> Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet
>> get exceptions
>
> Nit: FFmpeg does not have exceptions, it has error codes.
Ok, "avformat/hls: return r
Steven Liu (12021-08-04):
> Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet
> get exceptions
Nit: FFmpeg does not have exceptions, it has error codes.
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
From: Steven Liu
Should not modify to AVERROR_EOF value when get error number.
for example: return HTTP ERROR return value when cannot get fragments
from http protocol, for user get the point of problem.
Reported-by: bevis
Signed-off-by: Steven Liu
---
libavformat/hls.c | 4 ++--
1 file