Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
Based on a conversation that I had on IRC with Martin Storsjö, I misinterpreted the Apple documentation, and the only reason why '\' shows up in these documents is so that lines won't appear too long, particularly in the RFC. According to Martin, Apple's tools can't handle .m3u8 files that

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-09 Thread Aaron Levinson
I would rewrite the commit message as: "avformat/hlsenc: support multi-line TAG spans when parsing a playlist". Also, I thought you were going to have a common implementation for both hlsenc and hls? There are a duplicate implementations of read_chomp_line() in hls.c, hlsenc.c, and

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-08 Thread Steven Liu
2017-05-05 16:55 GMT+08:00 Steven Liu : > > > 2017-05-06 0:50 GMT+08:00 Steven Liu : > >> refer to: https://developer.apple.com/library/content/technotes/tn2288 >> /_index.html >> >> support to parse the EXT-X-KEY span multiple lines: >> #EXTM3U >>

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-05 Thread Steven Liu
2017-05-06 0:50 GMT+08:00 Steven Liu : > refer to: https://developer.apple.com/library/content/technotes/ > tn2288/_index.html > > support to parse the EXT-X-KEY span multiple lines: > #EXTM3U > #EXT-X-VERSION:3 > #EXT-X-TARGETDURATION:10 > #EXT-X-MEDIA-SEQUENCE:0 >

[FFmpeg-devel] [PATCH] avformat/hlsenc: support TAG span multiple lines when parse playlist

2017-05-05 Thread Steven Liu
refer to: https://developer.apple.com/library/content/technotes/tn2288/_index.html support to parse the EXT-X-KEY span multiple lines: #EXTM3U #EXT-X-VERSION:3 #EXT-X-TARGETDURATION:10 #EXT-X-MEDIA-SEQUENCE:0 #EXT-X-KEY:METHOD=AES-128,URI="/file.key", \