Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2018-01-11 Thread James Almer
On 1/11/2018 8:05 AM, James Cowgill wrote: > Hi, > > On 11/06/17 18:47, jamrial at gmail.com (James Almer) wrote: >> Fixes ticket #6413 >> >> Signed-off-by: James Almer >> --- >> The public key authentication also tries to use the password variable. I >> don't know if NULL is valid in that case

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2018-01-11 Thread James Cowgill
Hi, On 11/06/17 18:47, jamrial at gmail.com (James Almer) wrote: > Fixes ticket #6413 > > Signed-off-by: James Almer > --- > The public key authentication also tries to use the password variable. I > don't know if NULL is valid in that case or not. > Perhaps for that one it would be better to

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2017-06-17 Thread James Almer
On 6/17/2017 4:57 PM, Michael Niedermayer wrote: > On Fri, Jun 16, 2017 at 06:30:45PM -0300, James Almer wrote: >> On 6/11/2017 2:47 PM, James Almer wrote: >>> Fixes ticket #6413 >>> >>> Signed-off-by: James Almer >>> --- >>> The public key authentication also tries to use the

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2017-06-17 Thread Michael Niedermayer
On Fri, Jun 16, 2017 at 06:30:45PM -0300, James Almer wrote: > On 6/11/2017 2:47 PM, James Almer wrote: > > Fixes ticket #6413 > > > > Signed-off-by: James Almer > > --- > > The public key authentication also tries to use the password variable. I > > don't know if NULL is

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2017-06-16 Thread James Almer
On 6/11/2017 2:47 PM, James Almer wrote: > Fixes ticket #6413 > > Signed-off-by: James Almer > --- > The public key authentication also tries to use the password variable. I > don't know if NULL is valid in that case or not. > Perhaps for that one it would be better to replace

[FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2017-06-11 Thread James Almer
Fixes ticket #6413 Signed-off-by: James Almer --- The public key authentication also tries to use the password variable. I don't know if NULL is valid in that case or not. Perhaps for that one it would be better to replace the current usage of legacy API instead.