Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

On Tue, Sep 27, 2016 at 12:00:29PM -0700, Sophia Wang wrote: > Signed-off-by: Sophia Wang > --- > libavformat/matroskadec.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) applied thanks [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..7ee1c7a 100644 --- a/libavformat/matroskadec.c +++

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

On Fri, Sep 23, 2016 at 1:40 AM, Benoit Fouet wrote: > Hi, > > > On 22/09/2016 23:03, Sophia Wang wrote: > >> Signed-off-by: Sophia Wang >> --- >> libavformat/matroskadec.c | 13 - >> 1 file changed, 8 insertions(+), 5 deletions(-) >> >>

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Hi, On 22/09/2016 23:03, Sophia Wang wrote: Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..936690d 100644 ---

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 77b8a5d..936690d 100644 --- a/libavformat/matroskadec.c +++

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

I think you're right. Seems like the best solution is to maintain the number of calls to matroska_deliver_packet(); patch modification on the way. On Wed, Aug 31, 2016 at 6:30 PM, Michael Niedermayer wrote: > > On Mon, Aug 15, 2016 at 10:27:47AM -0700, Sophia Wang

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

On Mon, Aug 15, 2016 at 10:27:47AM -0700, Sophia Wang wrote: > Of the 3 functions that directly add to matroska->packets, 2 of them will > always return 0 afterwards, and the third (matroska_parse_rm_audio) will > only return something other than 0 in the case of AVERROR(ENOMEM) or >

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Of the 3 functions that directly add to matroska->packets, 2 of them will always return 0 afterwards, and the third (matroska_parse_rm_audio) will only return something other than 0 in the case of AVERROR(ENOMEM) or AVERROR(EINVAL). All 3 functions are called from matroska_parse_block, which

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

On Wed, Aug 10, 2016 at 10:24:08AM -0700, Sophia Wang wrote: > Signed-off-by: Sophia Wang > --- > libavformat/matroskadec.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index d07a092..8c809ad 100644 --- a/libavformat/matroskadec.c +++

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Apologies, I didn't realize that matroska->done was only checked in one place. But Nicolas raises a good point about the subtle change in behavior. I did not intend to change the overall behavior of the code for clients, so I'll modify the patch to restore the matroska->done check. On Tue, Aug 9,

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Le tridi 23 thermidor, an CCXXIV, Michael Niedermayer a écrit : > prior to this the "done" field was used to stop further work when > EOF was reached, now this is removed. > The patches commit message doesnt say anything why all reads for the > done field are removed or what if any performance

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

On Tue, Aug 02, 2016 at 01:11:57PM -0700, Sophia Wang wrote: > Signed-off-by: Sophia Wang > --- > libavformat/matroskadec.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c > index

[FFmpeg-devel] [PATCH] avformat/matroskadec: retain error codes in matroska_resync() and matroska_read_packet()

Signed-off-by: Sophia Wang --- libavformat/matroskadec.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index d07a092..f9693ca 100644 --- a/libavformat/matroskadec.c +++