Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-05-05 Thread wm4
On Sat, 5 May 2018 02:35:52 +0200 Carl Eugen Hoyos wrote: > 2018-05-04 15:00 GMT+02:00, wm4 : > > On Sat, 28 Apr 2018 19:24:21 +0200 > > wm4 wrote: > > > >> If the API user doesn't set avg_frame_rate, matroskaenc will write the

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-05-04 Thread Carl Eugen Hoyos
2018-05-04 15:00 GMT+02:00, wm4 : > On Sat, 28 Apr 2018 19:24:21 +0200 > wm4 wrote: > >> If the API user doesn't set avg_frame_rate, matroskaenc will write the >> current timebase as "default duration" for the video track. This makes >> no sense,

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-05-04 Thread wm4
On Sat, 28 Apr 2018 19:24:21 +0200 wm4 wrote: > If the API user doesn't set avg_frame_rate, matroskaenc will write the > current timebase as "default duration" for the video track. This makes > no sense, because the "default duration" implies the framerate of the > video.

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 Thread wm4
On Sat, 28 Apr 2018 21:18:47 +0200 Carl Eugen Hoyos wrote: > 2018-04-28 20:05 GMT+02:00, wm4 : > > On Sat, 28 Apr 2018 19:52:38 +0200 > > Carl Eugen Hoyos wrote: > > > >> 2018-04-28 19:24 GMT+02:00, wm4 :

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 Thread Carl Eugen Hoyos
2018-04-28 20:05 GMT+02:00, wm4 : > On Sat, 28 Apr 2018 19:52:38 +0200 > Carl Eugen Hoyos wrote: > >> 2018-04-28 19:24 GMT+02:00, wm4 : >> > If the API user doesn't set avg_frame_rate, matroskaenc will write the >> > current

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 Thread wm4
On Sat, 28 Apr 2018 19:52:38 +0200 Carl Eugen Hoyos wrote: > 2018-04-28 19:24 GMT+02:00, wm4 : > > If the API user doesn't set avg_frame_rate, matroskaenc will write the > > current timebase as "default duration" for the video track. This makes > > no

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 Thread Carl Eugen Hoyos
2018-04-28 19:24 GMT+02:00, wm4 : > If the API user doesn't set avg_frame_rate, matroskaenc will write the > current timebase as "default duration" for the video track. This makes > no sense, because the "default duration" implies the framerate of the > video. Since the

[FFmpeg-devel] [PATCH] avformat/matroskaenc: do not write timebase as framerate

2018-04-28 Thread wm4
If the API user doesn't set avg_frame_rate, matroskaenc will write the current timebase as "default duration" for the video track. This makes no sense, because the "default duration" implies the framerate of the video. Since the timebase is forced to 1/1000, this will make the resulting file claim