Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread mptcultist
From skimming the documents, FF's behavior appears to be correct. However, in both of the sidx atoms of the problematic file, they point to the same media and as such both point to the end of the file, meaning either will complete the fragment index incorrectly. I'm not sure what's to be done. On

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread Jan Ekström
On Fri, Feb 1, 2019 at 9:54 PM mptcultist wrote: > > ah, i couldn’t find a copy of the standard, i’ll look it over and figure out > what’s actually wrong, as the bug still remains. > ISOBMFF (14496-12) is available for free at https://standards.iso.org/ittf/PubliclyAvailableStandards/index.html

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread mptcultist
ah, i couldn’t find a copy of the standard, i’ll look it over and figure out what’s actually wrong, as the bug still remains. Sent from my iPhone > On Feb 1, 2019, at 2:12 PM, John Stebbins wrote: > >> On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote: >> 2019-01-30 19:44 GMT+01:00, no pls : >>>

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-02-01 Thread John Stebbins
On 1/30/19 1:18 PM, Carl Eugen Hoyos wrote: 2019-01-30 19:44 GMT+01:00, no pls : From: mptcultist fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572 Please wait for a

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-01-31 Thread Michael Niedermayer
On Sun, Jan 27, 2019 at 11:08:29AM -0500, agrecascino...@gmail.com wrote: > From: mptcultist > > fixes an issue where if the video size was very specific, ffmpeg would hang > from not filling the sidx_pts for all streams, due to not reading the last > sidx lump. for #7572 > > --- >

[FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-01-30 Thread agrecascino123
From: mptcultist fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572 --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-01-30 Thread Carl Eugen Hoyos
2019-01-30 19:44 GMT+01:00, no pls : > From: mptcultist > > fixes an issue where if the video size was very specific, > ffmpeg would hang from not filling the sidx_pts for all > streams, due to not reading the last sidx lump. for #7572 Please wait for a review from John who has promised to look

[FFmpeg-devel] [PATCH] avformat/mov: fix sidx size being doubled in offset.

2019-01-30 Thread no pls
From: mptcultist fixes an issue where if the video size was very specific, ffmpeg would hang from not filling the sidx_pts for all streams, due to not reading the last sidx lump. for #7572 --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git