Re: [FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun

2019-02-08 Thread Michael Niedermayer
On Thu, Feb 07, 2019 at 08:03:01PM +, Derek Buitenhuis wrote: > On 07/02/2019 19:30, Chris Cunningham wrote: > > This will reject the file entirely. The testcase I have (can share once > > chromium bug is fixed) was previously hitting an av_assert0 in > > mov_read_trun, arguably also a total re

Re: [FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun

2019-02-07 Thread Derek Buitenhuis
On 07/02/2019 19:30, Chris Cunningham wrote: > This will reject the file entirely. The testcase I have (can share once > chromium bug is fixed) was previously hitting an av_assert0 in > mov_read_trun, arguably also a total rejection ;). Recovery for this could > be pretty tricky since the dropped t

Re: [FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun

2019-02-07 Thread Chris Cunningham
This will reject the file entirely. The testcase I have (can share once chromium bug is fixed) was previously hitting an av_assert0 in mov_read_trun, arguably also a total rejection ;). Recovery for this could be pretty tricky since the dropped trun will break decode dependencies. I would be surpri

Re: [FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun

2019-02-07 Thread Derek Buitenhuis
On 07/02/2019 00:12, chcunningham wrote: > Detecting missing tfhd avoids re-using tfhd track info from the previous > moof. For files with multiple tracks, this may make a mess of the > avindex and fragindex, which can later trigger av_assert0 in > mov_read_trun(). > --- > libavformat/isom.h | 1

[FFmpeg-devel] [PATCH] avformat/mov.c: require tfhd to begin parsing trun

2019-02-06 Thread chcunningham
Detecting missing tfhd avoids re-using tfhd track info from the previous moof. For files with multiple tracks, this may make a mess of the avindex and fragindex, which can later trigger av_assert0 in mov_read_trun(). --- libavformat/isom.h | 1 + libavformat/mov.c | 10 ++ 2 files change