Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

2019-02-06 Thread Michael Niedermayer
On Tue, Feb 05, 2019 at 10:42:32AM -0800, Baptiste Coudurier wrote: > Hi Niki, > > > > On Feb 4, 2019, at 6:03 PM, Niki Bowe wrote: > > > > Hi Baptiste. > > I agree. This patch does cause it to fail in mov_write_header in the given > > example, by propagating the errors returned from

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

2019-02-05 Thread Baptiste Coudurier
Hi Niki, > On Feb 4, 2019, at 6:03 PM, Niki Bowe wrote: > > Hi Baptiste. > I agree. This patch does cause it to fail in mov_write_header in the given > example, by propagating the errors returned from mov_write_ac3_tag. > > It is not always extradata related. > Eg EAC3 parses the packets

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

2019-02-04 Thread Niki Bowe
Hi Baptiste. I agree. This patch does cause it to fail in mov_write_header in the given example, by propagating the errors returned from mov_write_ac3_tag. It is not always extradata related. Eg EAC3 parses the packets during muxing to build the dec3 atom. Perhaps this should be made extradata,

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

2019-02-04 Thread Baptiste Coudurier
Hi Nikolas, > On Feb 4, 2019, at 5:02 PM, Nikolas Bowe > wrote: > > Fixes a problem where a sample entry which cannot be written correctly > appears to succeed, but produces an invalid file. > For example, this command: > ffmpeg -f lavfi -i sine=frequency=1000:duration=5 -codec:a ac3

[FFmpeg-devel] [PATCH] avformat/movenc: Add more error checking when writing sample entries.

2019-02-04 Thread Nikolas Bowe
Fixes a problem where a sample entry which cannot be written correctly appears to succeed, but produces an invalid file. For example, this command: ffmpeg -f lavfi -i sine=frequency=1000:duration=5 -codec:a ac3 -movflags +empty_moov -frag_duration 500 /tmp/foo.mp4 produced a file with the