Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-05-05 Thread Gyan
On 04-05-2019 06:42 PM, Nicolas George wrote: Gyan (12019-05-02): The flow is avformat_write_header -> avformat_init_output -> init_muxer And in the last function, lines 293-385 (as of 7eba26451) carry out the checks, and which my patch skips. I missed this. My bad. The problem is that

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-05-04 Thread Nicolas George
Gyan (12019-05-02): > The flow is > > avformat_write_header -> avformat_init_output -> init_muxer > > And in the last function, lines 293-385 (as of 7eba26451) carry out the > checks, and which my patch skips. I missed this. My bad. > The problem is that there is no clean set of flags which

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-05-02 Thread Gyan
On 02-05-2019 03:23 PM, Nicolas George wrote: Gyan (12019-04-28): b) ffmpeg will call avformat_write_header for the output, which will likely fail because of the aforementioned codec parameter issues. Are you sure? It looks to me like avformat_write_header() does not perform checks by

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-05-02 Thread Nicolas George
Gyan (12019-04-28): > b) ffmpeg will call avformat_write_header for the output, which will likely > fail because of the aforementioned codec parameter issues. Are you sure? It looks to me like avformat_write_header() does not perform checks by itself, and null does not either. > The pipeline for

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Gyan
On 28-04-2019 04:15 PM, Nicolas George wrote: Gyan (12019-04-28): Corrupt streams in sufficiently intact containers (MP4, TS) so they can be demuxed but decoder context fields are incomplete/invalid, so ffmpeg won't streamcopy-mux them. Depending on the exact situation, I would use a repair

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Paul B Mahol
On 4/28/19, Gyan wrote: > > > On 28-04-2019 03:52 PM, Nicolas George wrote: >> Gyan (12019-04-26): >>> From 5ec154870d9c559037598b41736bf5b216a756e0 Mon Sep 17 00:00:00 2001 >>> From: Gyan Doshi >>> Date: Fri, 26 Apr 2019 18:31:33 +0530 >>> Subject: [PATCH] avformat/mux: skip parameter and pts

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Nicolas George
Gyan (12019-04-28): > Corrupt streams in sufficiently intact containers (MP4, TS) so they can be > demuxed but decoder context fields are incomplete/invalid, so ffmpeg won't > streamcopy-mux them. > > Depending on the exact situation, I would use a repair or analysis tool to > check them or

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Gyan
On 28-04-2019 03:52 PM, Nicolas George wrote: Gyan (12019-04-26): From 5ec154870d9c559037598b41736bf5b216a756e0 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 26 Apr 2019 18:31:33 +0530 Subject: [PATCH] avformat/mux: skip parameter and pts checks for data muxer Allows to dump a

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Gyan
On 28-04-2019 03:40 PM, Hendrik Leppkes wrote: On Sun, Apr 28, 2019 at 11:57 AM Michael Niedermayer wrote: On Sat, Apr 27, 2019 at 10:01:53AM +0530, Gyan wrote: On 27-04-2019 01:32 AM, Michael Niedermayer wrote: On Fri, Apr 26, 2019 at 06:38:37PM +0530, Gyan wrote: mux.c |9

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Nicolas George
Gyan (12019-04-26): > From 5ec154870d9c559037598b41736bf5b216a756e0 Mon Sep 17 00:00:00 2001 > From: Gyan Doshi > Date: Fri, 26 Apr 2019 18:31:33 +0530 > Subject: [PATCH] avformat/mux: skip parameter and pts checks for data muxer > > Allows to dump a malformed stream for external inspection or

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Gyan
On 28-04-2019 03:26 PM, Michael Niedermayer wrote: On Sat, Apr 27, 2019 at 10:01:53AM +0530, Gyan wrote: On 27-04-2019 01:32 AM, Michael Niedermayer wrote: On Fri, Apr 26, 2019 at 06:38:37PM +0530, Gyan wrote: mux.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Hendrik Leppkes
On Sun, Apr 28, 2019 at 11:57 AM Michael Niedermayer wrote: > > On Sat, Apr 27, 2019 at 10:01:53AM +0530, Gyan wrote: > > > > > > On 27-04-2019 01:32 AM, Michael Niedermayer wrote: > > >On Fri, Apr 26, 2019 at 06:38:37PM +0530, Gyan wrote: > > >> mux.c |9 - > > >> 1 file changed, 8

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-28 Thread Michael Niedermayer
On Sat, Apr 27, 2019 at 10:01:53AM +0530, Gyan wrote: > > > On 27-04-2019 01:32 AM, Michael Niedermayer wrote: > >On Fri, Apr 26, 2019 at 06:38:37PM +0530, Gyan wrote: > >> mux.c |9 - > >> 1 file changed, 8 insertions(+), 1 deletion(-) > >>d94a699f5dbc31a8ee8b7d1bdb33004d9cd95d46

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-26 Thread Gyan
On 27-04-2019 01:32 AM, Michael Niedermayer wrote: On Fri, Apr 26, 2019 at 06:38:37PM +0530, Gyan wrote: mux.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) d94a699f5dbc31a8ee8b7d1bdb33004d9cd95d46 0001-avformat-mux-skip-parameter-and-pts-checks-for-data-.patch From

Re: [FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-26 Thread Michael Niedermayer
On Fri, Apr 26, 2019 at 06:38:37PM +0530, Gyan wrote: > > mux.c |9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > d94a699f5dbc31a8ee8b7d1bdb33004d9cd95d46 > 0001-avformat-mux-skip-parameter-and-pts-checks-for-data-.patch > From 5ec154870d9c559037598b41736bf5b216a756e0 Mon

[FFmpeg-devel] [PATCH] avformat/mux: skip parameter and pts checks for data muxer

2019-04-26 Thread Gyan
From 5ec154870d9c559037598b41736bf5b216a756e0 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Fri, 26 Apr 2019 18:31:33 +0530 Subject: [PATCH] avformat/mux: skip parameter and pts checks for data muxer Allows to dump a malformed stream for external inspection or repair. --- libavformat/mux.c