Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-10 Thread Michael Niedermayer
On Tue, Apr 10, 2018 at 07:21:29PM +0530, Gyan Doshi wrote: > > > On 4/10/2018 4:49 AM, Michael Niedermayer wrote: > > >To implement generic "codec supported" checks, muxers would have to > >list what they support. > >There are 3 ways i know how this can be done in the current API > >1. the audi

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-10 Thread Gyan Doshi
On 4/10/2018 4:49 AM, Michael Niedermayer wrote: To implement generic "codec supported" checks, muxers would have to list what they support. There are 3 ways i know how this can be done in the current API 1. the audio_codec / video_codec / ... fields 2. the codec_tag array (this was in fact II

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-09 Thread Michael Niedermayer
On Fri, Apr 06, 2018 at 08:34:12PM +0530, Gyan Doshi wrote: > > On 4/5/2018 12:09 AM, Michael Niedermayer wrote: > > > >This does not work > >breaks fate-unknown_layout-ac3 > > > >also the tests mayb too strict, there are similar codec_ids like mpeg1/2 > >or jpeg variants which are all basically t

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-09 Thread Gyan Doshi
On 4/6/2018 8:34 PM, Gyan Doshi wrote: On 4/5/2018 12:09 AM, Michael Niedermayer wrote: This does not work breaks fate-unknown_layout-ac3 also the tests mayb too strict, there are similar codec_ids like mpeg1/2 or jpeg variants which are all basically the same from a muxers point of view

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-07 Thread Gyan Doshi
On 4/8/2018 1:19 AM, Carl Eugen Hoyos wrote: 2018-04-07 13:32 GMT+02:00, Gyan Doshi : Had an user on SE sometime back extract a video stream to a .h264 (in order to retime PTS). Does this work at all? With input -r, yes. For streams with b-pyramid, mp4box does. A warning would be suffi

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-07 Thread Carl Eugen Hoyos
2018-04-07 13:32 GMT+02:00, Gyan Doshi : > On 4/7/2018 4:35 PM, Carl Eugen Hoyos wrote: >> 2018-04-04 12:23 GMT+02:00, Gyan Doshi : >>> Validate codec of stream to be muxed except for data muxer. >> >> What issue does your patch fix? > > Had an user on SE sometime back extract a video stream to a .

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-07 Thread Gyan Doshi
On 4/7/2018 4:35 PM, Carl Eugen Hoyos wrote: 2018-04-04 12:23 GMT+02:00, Gyan Doshi : Validate codec of stream to be muxed except for data muxer. What issue does your patch fix? Had an user on SE sometime back extract a video stream to a .h264 (in order to retime PTS). The retiming didn't w

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-07 Thread Carl Eugen Hoyos
2018-04-04 12:23 GMT+02:00, Gyan Doshi : > Validate codec of stream to be muxed except for data muxer. What issue does your patch fix? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-06 Thread Gyan Doshi
On 4/5/2018 12:09 AM, Michael Niedermayer wrote: This does not work breaks fate-unknown_layout-ac3 also the tests mayb too strict, there are similar codec_ids like mpeg1/2 or jpeg variants which are all basically the same from a muxers point of view Revised patch passes FATE. Set looser cond

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-04 Thread Gyan Doshi
On 4/5/2018 12:09 AM, Michael Niedermayer wrote: This does not work breaks fate-unknown_layout-ac3 Silly mistake. Fixed locally. also the tests mayb too strict, there are similar codec_ids like mpeg1/2 or jpeg variants which are all basically the same from a muxers point of view Will ch

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-04 Thread Michael Niedermayer
On Wed, Apr 04, 2018 at 03:53:25PM +0530, Gyan Doshi wrote: > rawenc.c | 10 ++ > 1 file changed, 10 insertions(+) > c144b841348e9af26d80e0014daf63c5b2477467 > 0001-avformat-rawenc-check-stream-type.patch > From f86916b9e1128a4e41501f4d5b189749a344862f Mon Sep 17 00:00:00 2001 > From:

[FFmpeg-devel] [PATCH] avformat/rawenc: check stream type

2018-04-04 Thread Gyan Doshi
From f86916b9e1128a4e41501f4d5b189749a344862f Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Wed, 4 Apr 2018 15:45:18 +0530 Subject: [PATCH] avformat/rawenc: check stream type Validate codec of stream to be muxed except for data muxer. --- libavformat/rawenc.c | 10 ++ 1 file changed, 1