Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-12-02 Thread gga
On 1/12/19 09:05, Andreas Rheinhardt wrote: ggarr...@gmail.com: From: Gonzalo Garramuño Moved the check inside and at the end of the if (pktl) as per Michael Niedermayer's suggestion. This patch is based on one from Blake Senftner ( bsenftner at earthlink.net ). The hanging in

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-12-01 Thread Michael Niedermayer
On Sun, Dec 01, 2019 at 12:05:00PM +, Andreas Rheinhardt wrote: > ggarr...@gmail.com: > > From: Gonzalo Garramuño > > > > Moved the check inside and at the end of the if (pktl) as per Michael > > Niedermayer's suggestion. > > This patch is based on one from Blake Senftner ( bsenftner at

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-12-01 Thread Andreas Rheinhardt
ggarr...@gmail.com: > From: Gonzalo Garramuño > > Moved the check inside and at the end of the if (pktl) as per Michael > Niedermayer's suggestion. > This patch is based on one from Blake Senftner ( bsenftner at earthlink.net ). > > The hanging in av_read_frame can be reproduced with an rtmp

[FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-12-01 Thread ggarra13
From: Gonzalo Garramuño Moved the check inside and at the end of the if (pktl) as per Michael Niedermayer's suggestion. This patch is based on one from Blake Senftner ( bsenftner at earthlink.net ). The hanging in av_read_frame can be reproduced with an rtmp stream that is aborted midway and

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-29 Thread gga
On 29/11/19 15:35, Michael Niedermayer wrote: also, do we have a testcase where this loop hangs ? if not please provide a testcase I don't have an easy testcase, but it can be seen with any rtmp stream.  A full test case can be reproduced like this: Compile and create a nginx server like it

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-29 Thread Carl Eugen Hoyos
Am Sa., 30. Nov. 2019 um 00:52 Uhr schrieb : > > From: Gonzalo Garramuño > > Moved the check inside and at the end of the if (pktl) as per Michael > Niedermayer's suggestion. > This patch is based on one from bsenftner at earthlink.net. Please mention his name as suggested. Carl Eugen

[FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-29 Thread ggarra13
From: Gonzalo Garramuño Moved the check inside and at the end of the if (pktl) as per Michael Niedermayer's suggestion. This patch is based on one from bsenftner at earthlink.net. The hanging in av_read_frame can be reproduced with an rtmp stream that is aborted midway and ffplay (for

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-29 Thread Michael Niedermayer
On Thu, Nov 28, 2019 at 08:58:54PM -0300, ggarr...@gmail.com wrote: > From: Gonzalo Garramuño > > Moved the check inside if (pktl) as per Michael Niedermayer's suggestion. > This patch is based on one from bsenftner at earthlink.net. > --- > libavformat/utils.c | 5 + > 1 file changed, 5

[FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-28 Thread ggarra13
From: Gonzalo Garramuño Moved the check inside if (pktl) as per Michael Niedermayer's suggestion. This patch is based on one from bsenftner at earthlink.net. --- libavformat/utils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-27 Thread Michael Niedermayer
On Tue, Nov 26, 2019 at 02:45:05PM -0300, gga wrote: > > > On 26/11/19 14:31, Michael Niedermayer wrote: > >On Thu, Nov 21, 2019 at 06:27:10PM -0300, ggarr...@gmail.com wrote: > >>From: Gonzalo Garramuño > >> > >>This patch is based on a patch by bsenftner at earthlink.net. > >>--- > >>

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-26 Thread gga
On 26/11/19 14:31, Michael Niedermayer wrote: On Thu, Nov 21, 2019 at 06:27:10PM -0300, ggarr...@gmail.com wrote: From: Gonzalo Garramuño This patch is based on a patch by bsenftner at earthlink.net. --- libavformat/utils.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-26 Thread Michael Niedermayer
On Thu, Nov 21, 2019 at 06:27:10PM -0300, ggarr...@gmail.com wrote: > From: Gonzalo Garramuño > > This patch is based on a patch by bsenftner at earthlink.net. > --- > libavformat/utils.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/libavformat/utils.c b/libavformat/utils.c >

Re: [FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-24 Thread gga
Friendly ping.  Does the patch need anything else for approval? On 21/11/19 18:27, ggarr...@gmail.com wrote: From: Gonzalo Garramuño This patch is based on a patch by bsenftner at earthlink.net. --- libavformat/utils.c | 5 + 1 file changed, 5 insertions(+) diff --git

[FFmpeg-devel] [PATCH] avformat/utils.c: allows av_read_frame to return after a timeout period.

2019-11-21 Thread ggarra13
From: Gonzalo Garramuño This patch is based on a patch by bsenftner at earthlink.net. --- libavformat/utils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 8196442dd1..c3c2c77c0c 100644 --- a/libavformat/utils.c +++