Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: This patch has a strange side effect. With it gst-libav1.0 (version 1.3.2) gets compiled incorrectly so that when the plugin is loaded by gstreamer it segfaults: ERROR: Caught a segmentation fault while loading plugin file: Please provide a backtrace. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection
On 22.07.2014 02:12, Andreas Cadhalpun wrote:
On 21.07.2014 23:18, Carl Eugen Hoyos wrote:
Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes:
This patch has a strange side effect. With it gst-libav1.0
(version 1.3.2) gets compiled incorrectly so that when the
plugin is loaded by gstreamer it segfaults:
ERROR: Caught a segmentation fault while loading plugin file:
Please provide a backtrace.
Attached.
The problem is that in_plugin-long_name is a null pointer.
Attached patch fixes the problem.
Best regards,
Andreas
From 316c472c4d5502743890daa344fbd51aaca5a561 Mon Sep 17 00:00:00 2001
From: Andreas Cadhalpun andreas.cadhal...@googlemail.com
Date: Tue, 22 Jul 2014 03:32:03 +0200
Subject: [PATCH] libavformat/img2dec.c: Add a long_name to the piped image
demuxers
This fixes segfaults in gst-libav1.0 compiled against FFmpeg 2.3.
---
libavformat/img2dec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c
index cda4996..f978007 100644
--- a/libavformat/img2dec.c
+++ b/libavformat/img2dec.c
@@ -666,6 +666,7 @@ static const AVClass imgname ## _class = {\
};\
AVInputFormat ff_image_ ## imgname ## _pipe_demuxer = {\
.name = AV_STRINGIFY(imgname) _pipe,\
+.long_name = NULL_IF_CONFIG_SMALL(piped AV_STRINGIFY(imgname) sequence),\
.priv_data_size = sizeof(VideoDemuxData),\
.read_probe = imgname ## _probe,\
.read_header= ff_img_read_header,\
--
2.0.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Re: [FFmpeg-devel] [PATCH] avformat: Add image3 demuxers with format autodetection
On Tue, Jul 22, 2014 at 03:34:45AM +0200, Andreas Cadhalpun wrote: On 22.07.2014 02:12, Andreas Cadhalpun wrote: On 21.07.2014 23:18, Carl Eugen Hoyos wrote: Andreas Cadhalpun andreas.cadhalpun at googlemail.com writes: This patch has a strange side effect. With it gst-libav1.0 (version 1.3.2) gets compiled incorrectly so that when the plugin is loaded by gstreamer it segfaults: ERROR: Caught a segmentation fault while loading plugin file: Please provide a backtrace. Attached. The problem is that in_plugin-long_name is a null pointer. Attached patch fixes the problem. Best regards, Andreas img2dec.c |1 + 1 file changed, 1 insertion(+) 81880958a8d49da4585ac278c867059912b1b421 libavformat-img2dec.c:Addalong_nametothepipedimagedemuxers.patch From 316c472c4d5502743890daa344fbd51aaca5a561 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun andreas.cadhal...@googlemail.com Date: Tue, 22 Jul 2014 03:32:03 +0200 Subject: [PATCH] libavformat/img2dec.c: Add a long_name to the piped image demuxers This fixes segfaults in gst-libav1.0 compiled against FFmpeg 2.3. applied, also locally backported to release/2.3 having a long name is better than not having one ... but note, long_name can be NULL that is perfectly legal and is the case with --enable-small [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
