Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-30 Thread Clément Bœsch
On Thu, Oct 29, 2015 at 07:49:44PM -0400, Ganesh Ajjanagadde wrote: [...] > although you did explain to me where optimizations could be useful at > an algorithmic level privately, I take this as an opportunity to > request for general comments on places that people think could benefit > from

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-30 Thread Michael Niedermayer
On Tue, Oct 27, 2015 at 08:18:34PM -0400, Ganesh Ajjanagadde wrote: > av_gcd is now always defined regardless of input. This documents this > change in the "documented API". Two benefits (closely related): > 1. The function is robust, and there is no need to worry about INT64_MIN, etc. > > 2.

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-30 Thread Ganesh Ajjanagadde
On Fri, Oct 30, 2015 at 12:16 PM, Michael Niedermayer wrote: > On Tue, Oct 27, 2015 at 08:18:34PM -0400, Ganesh Ajjanagadde wrote: >> av_gcd is now always defined regardless of input. This documents this >> change in the "documented API". Two benefits (closely related): >>

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-29 Thread Michael Niedermayer
On Wed, Oct 28, 2015 at 10:49:08PM -0400, Ganesh Ajjanagadde wrote: > On Wed, Oct 28, 2015 at 10:09 AM, Ganesh Ajjanagadde > wrote: > > On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde > > wrote: > >> av_gcd is now always defined regardless of

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-29 Thread Ganesh Ajjanagadde
On Thu, Oct 29, 2015 at 4:51 PM, Michael Niedermayer wrote: > On Wed, Oct 28, 2015 at 10:49:08PM -0400, Ganesh Ajjanagadde wrote: >> On Wed, Oct 28, 2015 at 10:09 AM, Ganesh Ajjanagadde >> wrote: >> > On Tue, Oct 27, 2015 at 8:18 PM, Ganesh

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-28 Thread Ganesh Ajjanagadde
On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde wrote: > av_gcd is now always defined regardless of input. This documents this > change in the "documented API". Two benefits (closely related): > 1. The function is robust, and there is no need to worry about INT64_MIN,

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-28 Thread Ganesh Ajjanagadde
On Wed, Oct 28, 2015 at 10:09 AM, Ganesh Ajjanagadde wrote: > On Tue, Oct 27, 2015 at 8:18 PM, Ganesh Ajjanagadde > wrote: >> av_gcd is now always defined regardless of input. This documents this >> change in the "documented API". Two benefits

[FFmpeg-devel] [PATCH] avutil/mathematics: correct documentation for av_gcd

2015-10-27 Thread Ganesh Ajjanagadde
av_gcd is now always defined regardless of input. This documents this change in the "documented API". Two benefits (closely related): 1. The function is robust, and there is no need to worry about INT64_MIN, etc. 2. Clients of av_gcd, like av_reduce, can now be made fully correct. Currently,