Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-18 Thread Michael Niedermayer
On Thu, Dec 18, 2014 at 05:11:29PM +0100, Lukasz Marek wrote: > On 18 December 2014 at 10:41, Michael Niedermayer wrote: > > > > On Thu, Dec 18, 2014 at 01:29:39AM +0100, Lukasz Marek wrote: > > > On 18.12.2014 01:09, Michael Niedermayer wrote: > > > >On Wed, Dec 17, 2014 at 10:59:37PM +0100, Luka

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-18 Thread Lukasz Marek
On 18 December 2014 at 10:41, Michael Niedermayer wrote: > > On Thu, Dec 18, 2014 at 01:29:39AM +0100, Lukasz Marek wrote: > > On 18.12.2014 01:09, Michael Niedermayer wrote: > > >On Wed, Dec 17, 2014 at 10:59:37PM +0100, Lukasz Marek wrote: > > >>On 15.12.2014 14:18, Michael Niedermayer wrote: >

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-18 Thread Michael Niedermayer
On Thu, Dec 18, 2014 at 01:29:39AM +0100, Lukasz Marek wrote: > On 18.12.2014 01:09, Michael Niedermayer wrote: > >On Wed, Dec 17, 2014 at 10:59:37PM +0100, Lukasz Marek wrote: > >>On 15.12.2014 14:18, Michael Niedermayer wrote: > cmdutils.c |8 ++-- > 1 file changed, 6 insertion

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-17 Thread Lukasz Marek
On 18.12.2014 01:09, Michael Niedermayer wrote: On Wed, Dec 17, 2014 at 10:59:37PM +0100, Lukasz Marek wrote: On 15.12.2014 14:18, Michael Niedermayer wrote: cmdutils.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) 8d012a5193b0440717f89d920661913ef160e674 0001-cmdutils-d

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-17 Thread Michael Niedermayer
On Wed, Dec 17, 2014 at 10:59:37PM +0100, Lukasz Marek wrote: > On 15.12.2014 14:18, Michael Niedermayer wrote: > >> cmdutils.c |8 ++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > >>8d012a5193b0440717f89d920661913ef160e674 > >>0001-cmdutils-dont-call-read_header-before-listin

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-17 Thread Lukasz Marek
On 15.12.2014 14:18, Michael Niedermayer wrote: cmdutils.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) 8d012a5193b0440717f89d920661913ef160e674 0001-cmdutils-dont-call-read_header-before-listing-device.patch From 332bb7456c498518ea72dfdaa0e8c3e76d383f21 Mon Sep 17 00:00

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-15 Thread Michael Niedermayer
On Mon, Dec 15, 2014 at 12:36:49AM +0100, Lukasz Marek wrote: > On 15.12.2014 00:33, Lukasz Marek wrote: > >List device callback must be able to return valid list without opening > >device. > >This callback should return input values for open function, not vice-versa. > >Read header funtion is ver

Re: [FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-14 Thread Lukasz Marek
On 15.12.2014 00:33, Lukasz Marek wrote: List device callback must be able to return valid list without opening device. This callback should return input values for open function, not vice-versa. Read header funtion is very likey to fail without proper configuration provided. Signed-off-by: Luka

[FFmpeg-devel] [PATCH] cmdutils: dont call read_header before listing devices

2014-12-14 Thread Lukasz Marek
List device callback must be able to return valid list without opening device. This callback should return input values for open function, not vice-versa. Read header funtion is very likey to fail without proper configuration provided. Signed-off-by: Lukasz Marek --- cmdutils.c | 3 +-- 1 file c