Re: [FFmpeg-devel] [PATCH] configure/rtmpdh: Fix OpenSSL 1.1.0 support

2017-02-23 Thread Stefan _
Am 23.02.2017 um 02:07 schrieb Michael Niedermayer: > On Wed, Feb 22, 2017 at 11:15:45PM +, Stefan _ wrote: > >> From: sfan5 > Is it intended that theres no full name in the git author field ? > > [...] Yes that's intended. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] configure/rtmpdh: Fix OpenSSL 1.1.0 support

2017-02-22 Thread Michael Niedermayer
On Wed, Feb 22, 2017 at 11:15:45PM +, Stefan _ wrote: > The rtmpdh patch was kinda (completly) broken, fixed patch is attached. > > Concerning LibreSSL: > They use OPENSSL_VERSION_NUMBER = 0x2050200fL which breaks the other > openssl code in tls_openssl.c anyway, > so LibreSSL support should

Re: [FFmpeg-devel] [PATCH] configure/rtmpdh: Fix OpenSSL 1.1.0 support

2017-02-22 Thread Stefan _
The rtmpdh patch was kinda (completly) broken, fixed patch is attached. Concerning LibreSSL: They use OPENSSL_VERSION_NUMBER = 0x2050200fL which breaks the other openssl code in tls_openssl.c anyway, so LibreSSL support should probably be worried about in a different patch. From 0edf1d179824fa640

Re: [FFmpeg-devel] [PATCH] configure/rtmpdh: Fix OpenSSL 1.1.0 support

2017-02-22 Thread Ricardo Constantino
On 22 February 2017 at 15:17, Stefan _ wrote: > 1) configure only looks for OPENSSL_init_ssl using pkg-config, this > breaks in case pkg-config is not available (cross-compiling) > > > 2) The rtmpdh code uses the DH struct from OpenSSL which was made > private in the 1.1 series > > Any idea if th

[FFmpeg-devel] [PATCH] configure/rtmpdh: Fix OpenSSL 1.1.0 support

2017-02-22 Thread Stefan _
1) configure only looks for OPENSSL_init_ssl using pkg-config, this breaks in case pkg-config is not available (cross-compiling) 2) The rtmpdh code uses the DH struct from OpenSSL which was made private in the 1.1 series From 5cc140f85d8d7551ac0a2c51d5023bd8ba75ba4b Mon Sep 17 00:00:00 2001 F