Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-22 Thread Nicolas George 
Le decadi 30 vendémiaire, an CCXXIII, Lukasz Marek a écrit :
 Building with static link is much slower.
 I agree patch is wrong,  it could be controlled by separate option, just
  for devel, but nvm.

It can be controlled by LD_LIBRARY_PATH, as Derek pointed out. I use this
(zsh):

libs=($src/lib*(/:t))
ld_library_path=($build/${^libs})
export LD_LIBRARY_PATH=${(j.:.)ld_library_path}

Note that what you proposed could devolve into a security issue for people
building in /tmp or similar directories: once the build dir has been
cleaned, any user can create it and hijack all users' ffmpeg sessions.

Regards,

-- 
  Nicolas George


signature.asc
Description: Digital signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-21 Thread Derek Buitenhuis 
On 10/21/2014 8:21 AM, Carl Eugen Hoyos wrote:
 This sounds like a very bad idea to me

I agree. It's not nice to have remnants of the build process in the
installed binaries.

If you need to run them during development, use LD_LIBRARY_PATH or
or build statically.

- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-21 Thread Lukasz Marek 
On 21 October 2014 12:01, Derek Buitenhuis derek.buitenh...@gmail.com
wrote:

 On 10/21/2014 8:21 AM, Carl Eugen Hoyos wrote:
  This sounds like a very bad idea to me

 I agree. It's not nice to have remnants of the build process in the
 installed binaries.

 If you need to run them during development, use LD_LIBRARY_PATH or
 or build statically.


Building with static link is much slower.
I agree patch is wrong,  it could be controlled by separate option, just
 for devel, but nvm.
Thx for pointing an issue.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-20 Thread Carl Eugen Hoyos 
Lukasz Marek lukasz.m.luki2 at gmail.com writes:

 This commit allows to run programs linked 
 dynamically in build dir without installing.

Sorry if I misunderstand:
Doesn't this patch change the properties of the 
installed binaries?

Carl Eugen

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: add build tree's directories to rpath

2014-10-20 Thread Lukasz Marek 
W dniu wtorek, 21 października 2014 Carl Eugen Hoyos ceho...@ag.or.at
napisał(a):

 Lukasz Marek lukasz.m.luki2 at gmail.com writes:

  This commit allows to run programs linked
  dynamically in build dir without installing.

 Sorry if I misunderstand:
 Doesn't this patch change the properties of the
 installed binaries?


if you run
configure --enable-rpath --disable-static --enable-shared
make
make install
then installed binaries of the fftolls will have more paths defined to look
libraries for.

but The goal is to allow to run fftool in build tree without installing.
it really simpliefies and speed up recompilation during development.

Now I'm not sure if other option should be added to enable it.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel