Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-02-02 Thread Marton Balint
On Sun, 20 Dec 2015, Matthias Hunstock wrote: As it is already written in the documentation, BMD DeckLink cards are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). Currently the value is hardcoded to 2. Introduces new option. Signed-off-by: Matthias Hunstock

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-02-02 Thread Deti Fliegl
Hi Matthias, thanks for adding this necessary option. Please commit this patch. Deti On 02.02.16 20:58, Marton Balint wrote: On Sun, 20 Dec 2015, Matthias Hunstock wrote: As it is already written in the documentation, BMD DeckLink cards are capable of capturing 2, 8 or 16 audio channels

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-02-02 Thread Marton Balint
On Tue, 2 Feb 2016, Deti Fliegl wrote: Hi Matthias, thanks for adding this necessary option. Please commit this patch. Deti On 02.02.16 20:58, Marton Balint wrote: On Sun, 20 Dec 2015, Matthias Hunstock wrote: As it is already written in the documentation, BMD DeckLink cards are capable

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-01-06 Thread Matthias Hunstock
Am 06.01.2016 um 04:08 schrieb Michael Niedermayer: > any patch that was forgotten and should be applied ? > just asking as your comment sounds a bit in that direction Yes, there was some discussion but no further action. But this is the first patch submitted by me, so I don't fully know the

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-01-05 Thread Matthias Hunstock
Am 20.12.2015 um 12:57 schrieb Matthias Hunstock: > As it is already written in the documentation, BMD DeckLink cards > are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). > Currently the value is hardcoded to 2. Introduces new option. Any more opinions on this? I'd like to add

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-01-05 Thread Dave Rice
> On Jan 5, 2016, at 10:38 AM, Matthias Hunstock wrote: > > Am 20.12.2015 um 12:57 schrieb Matthias Hunstock: >> As it is already written in the documentation, BMD DeckLink cards >> are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). >> Currently the

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2016-01-05 Thread Michael Niedermayer
On Tue, Jan 05, 2016 at 04:38:06PM +0100, Matthias Hunstock wrote: > Am 20.12.2015 um 12:57 schrieb Matthias Hunstock: > > As it is already written in the documentation, BMD DeckLink cards > > are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). > > Currently the value is hardcoded

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-22 Thread Dave Rice
> On Dec 20, 2015, at 9:28 AM, Matthias Hunstock wrote: > > Am 20.12.2015 um 15:11 schrieb Nicolas George: >> Le decadi 30 frimaire, an CCXXIV, Matthias Hunstock a écrit : >>> Decklink cards actually do just some bitbanging: take digital input in >>> "raw" format (AFAIK

[FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Matthias Hunstock
As it is already written in the documentation, BMD DeckLink cards are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). Currently the value is hardcoded to 2. Introduces new option. Signed-off-by: Matthias Hunstock --- doc/indevs.texi | 13

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Matthias Hunstock
Am 19.12.2015 um 23:29 schrieb Timothy Gu: >> PS. I did not find any ressources on how to properly name new FFmpeg >> options, e.g. to be consistent. Using the existing "ac" option did >> not work. > In this situation, it is always good to check what others are using :) > > In this case, all the

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Carl Eugen Hoyos
Matthias Hunstock fem.tu-ilmenau.de> writes: > +/* Check audio channel option for valid values: 2, 8 or 16 */ > +switch (cctx->audio_channels) { > +case 2: > +case 8: If decklink provides 8 channels, are they supposed to be in a specific layout or could they implement

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Matthias Hunstock
Am 20.12.2015 um 14:53 schrieb Nicolas George: > Le decadi 30 frimaire, an CCXXIV, Matthias Hunstock a écrit : >> SDI just transports 16 mono channels of audio, without any implied >> semantic of what is in there. So the closest matching layouts are 2.0, >> 8.0 and 16.0, if they existed. > > That

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Matthias Hunstock
Am 20.12.2015 um 13:16 schrieb Carl Eugen Hoyos: > Matthias Hunstock fem.tu-ilmenau.de> writes: > >> +/* Check audio channel option for valid values: 2, 8 or 16 */ >> +switch (cctx->audio_channels) { >> +case 2: >> +case 8: > > If decklink provides 8 channels, are they

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Nicolas George
Le decadi 30 frimaire, an CCXXIV, Matthias Hunstock a écrit : > SDI just transports 16 mono channels of audio, without any implied > semantic of what is in there. So the closest matching layouts are 2.0, > 8.0 and 16.0, if they existed. That does not mean anything. The channel layout called 5.1

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Matthias Hunstock
Am 20.12.2015 um 15:11 schrieb Nicolas George: > Le decadi 30 frimaire, an CCXXIV, Matthias Hunstock a écrit : >> Decklink cards actually do just some bitbanging: take digital input in >> "raw" format (AFAIK UYVY422 10 bit, PCM 16bit) and copy that into your RAM. > > Take digital input... from

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-20 Thread Nicolas George
Le decadi 30 frimaire, an CCXXIV, Matthias Hunstock a écrit : > Decklink cards actually do just some bitbanging: take digital input in > "raw" format (AFAIK UYVY422 10 bit, PCM 16bit) and copy that into your RAM. Take digital input... from where? > Another possibility is to demux each channel as

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-19 Thread Matthias Hunstock
Am 18.12.2015 um 20:25 schrieb Matthias Hunstock: > Introduces new option. PS. I did not find any ressources on how to properly name new FFmpeg options, e.g. to be consistent. Using the existing "ac" option did not work. I would like to add some more features, like selection of video and/or

Re: [FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-19 Thread Timothy Gu
Hi, On Sat, Dec 19, 2015 at 11:23 AM Matthias Hunstock < matthias.hunst...@tu-ilmenau.de> wrote: > Am 18.12.2015 um 20:25 schrieb Matthias Hunstock: > > Introduces new option. > > PS. I did not find any ressources on how to properly name new FFmpeg > options, e.g. to be consistent. Using the

[FFmpeg-devel] [PATCH] decklink: support all valid numbers of audio channels

2015-12-18 Thread Matthias Hunstock
As it is already written in the documentation, BMD DeckLink cards are capable of capturing 2, 8 or 16 audio channels (for SDI Inputs). Currently the value is hardcoded to 2. Introduces new option. Signed-off-by: Matthias Hunstock --- doc/indevs.texi | 13