Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-18 Thread Carl Eugen Hoyos
2018-05-18 3:41 GMT+02:00, Rostislav Pehlivanov : > Pushed, thanks > Its a bittersweet victory, took 3 years but its finally done. Is it possible that you don't see that a "victory" always has a disadvantage? Carl Eugen ___

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-17 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:26, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-14 Thread Rostislav Pehlivanov
On 14 May 2018 at 23:59, Hendrik Leppkes wrote: > On Tue, May 15, 2018 at 12:30 AM, Rostislav Pehlivanov > wrote: > > On 14 May 2018 at 22:57, Mark Thompson wrote: > > > >> On 14/05/18 22:38, Rostislav Pehlivanov wrote: > >> > On 12 May

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-14 Thread Hendrik Leppkes
On Tue, May 15, 2018 at 12:30 AM, Rostislav Pehlivanov wrote: > On 14 May 2018 at 22:57, Mark Thompson wrote: > >> On 14/05/18 22:38, Rostislav Pehlivanov wrote: >> > On 12 May 2018 at 20:49, Rostislav Pehlivanov >> wrote: >> >> On 8

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-14 Thread Mark Thompson
On 14/05/18 23:30, Rostislav Pehlivanov wrote: > On 14 May 2018 at 22:57, Mark Thompson wrote: >> On 14/05/18 22:38, Rostislav Pehlivanov wrote: >>> On 12 May 2018 at 20:49, Rostislav Pehlivanov >> wrote: On 8 November 2017 at 21:26, Rostislav Pehlivanov

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-14 Thread Rostislav Pehlivanov
On 14 May 2018 at 22:57, Mark Thompson wrote: > On 14/05/18 22:38, Rostislav Pehlivanov wrote: > > On 12 May 2018 at 20:49, Rostislav Pehlivanov > wrote: > >> On 8 November 2017 at 21:26, Rostislav Pehlivanov > >> wrote: > >> > >>>

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-14 Thread Mark Thompson
On 14/05/18 22:38, Rostislav Pehlivanov wrote: > On 12 May 2018 at 20:49, Rostislav Pehlivanov wrote: >> On 8 November 2017 at 21:26, Rostislav Pehlivanov >> wrote: >> >>> Signed-off-by: Rostislav Pehlivanov >>> --- >>>

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-14 Thread Rostislav Pehlivanov
On 12 May 2018 at 20:49, Rostislav Pehlivanov wrote: > > > On 8 November 2017 at 21:26, Rostislav Pehlivanov > wrote: > >> Signed-off-by: Rostislav Pehlivanov >> --- >> doc/developer.texi | 3 +++ >> 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2018-05-12 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:26, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Fri, Nov 10, 2017 at 12:18:07AM +0100, Aurelien Jacobs wrote: [...] > > > Also, allowing this but not the mixed statements and declarations means > > > this is a style decision and not a technical one anymore. > > Allowing limiting the scope of a variable to a loop seems like a > technical

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Aurelien Jacobs
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: > On 11/9/2017 2:46 PM, Clément Bœsch wrote: > > On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: > >> Signed-off-by: Rostislav Pehlivanov > >> --- > >> doc/developer.texi | 3 +++ > >> 1 file

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread James Almer
On 11/9/2017 5:08 PM, Clément Bœsch wrote: > On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: > [...] >>> - this require a Changelog entry as it has a technical impact (which could >>> be considered negligible). >> >> No, Changelog is not for this kind of change. >> > > Sorry, I

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Thu, Nov 09, 2017 at 04:56:07PM -0300, James Almer wrote: [...] > > - this require a Changelog entry as it has a technical impact (which could > > be considered negligible). > > No, Changelog is not for this kind of change. > Sorry, I should have elaborated: I meant to document in the

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread James Almer
On 11/9/2017 2:46 PM, Clément Bœsch wrote: > On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: >> Signed-off-by: Rostislav Pehlivanov >> --- >> doc/developer.texi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/doc/developer.texi

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-09 Thread Clément Bœsch
On Wed, Nov 08, 2017 at 09:26:13PM +, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451 100644 >

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread James Almer
On 11/8/2017 9:39 PM, Rostislav Pehlivanov wrote: > On 8 November 2017 at 23:05, Mark Thompson wrote: > >> On 08/11/17 22:41, Rostislav Pehlivanov wrote: >>> On 8 November 2017 at 22:20, Mark Thompson wrote: >>> On 08/11/17 22:03, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 23:05, Mark Thompson wrote: > On 08/11/17 22:41, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 22:20, Mark Thompson wrote: > > > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: > >>> On 8 November 2017 at 21:49, Mark Thompson

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 23:09, James Almer wrote: > On 11/8/2017 7:41 PM, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 22:20, Mark Thompson wrote: > > > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: > >>> On 8 November 2017 at 21:49, Mark Thompson

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread James Almer
On 11/8/2017 8:05 PM, Mark Thompson wrote: > On 08/11/17 22:41, Rostislav Pehlivanov wrote: >> On 8 November 2017 at 22:20, Mark Thompson wrote: >> >>> On 08/11/17 22:03, Rostislav Pehlivanov wrote: On 8 November 2017 at 21:49, Mark Thompson wrote: >

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Mark Thompson
On 08/11/17 22:41, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:20, Mark Thompson wrote: > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: >>> On 8 November 2017 at 21:49, Mark Thompson wrote: >>> On 08/11/17 21:26, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread James Almer
On 11/8/2017 7:41 PM, Rostislav Pehlivanov wrote: > On 8 November 2017 at 22:20, Mark Thompson wrote: > >> On 08/11/17 22:03, Rostislav Pehlivanov wrote: >>> On 8 November 2017 at 21:49, Mark Thompson wrote: >>> On 08/11/17 21:26, Rostislav Pehlivanov wrote:

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 22:20, Mark Thompson wrote: > On 08/11/17 22:03, Rostislav Pehlivanov wrote: > > On 8 November 2017 at 21:49, Mark Thompson wrote: > > > >> On 08/11/17 21:26, Rostislav Pehlivanov wrote: > >>> Signed-off-by: Rostislav Pehlivanov

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Mark Thompson
On 08/11/17 22:03, Rostislav Pehlivanov wrote: > On 8 November 2017 at 21:49, Mark Thompson wrote: > >> On 08/11/17 21:26, Rostislav Pehlivanov wrote: >>> Signed-off-by: Rostislav Pehlivanov >>> --- >>> doc/developer.texi | 3 +++ >>> 1 file changed, 3

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:49, Mark Thompson wrote: > On 08/11/17 21:26, Rostislav Pehlivanov wrote: > > Signed-off-by: Rostislav Pehlivanov > > --- > > doc/developer.texi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/doc/developer.texi

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Carl Eugen Hoyos
2017-11-08 22:49 GMT+01:00 Mark Thompson : > On 08/11/17 21:26, Rostislav Pehlivanov wrote: >> +@item >> +for loops with variable definition (@samp{for (int i = 0; i < 8; i++)}); > Can you comment on what the consequences would be for platform support? A similar-looking issue

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
On 8 November 2017 at 21:45, Carl Eugen Hoyos wrote: > 2017-11-08 22:26 GMT+01:00 Rostislav Pehlivanov : > > > +@item > > +for loops with variable definition (@samp{for (int i = 0; i < 8; i++)}); > > Don't you think that this makes the code slightly

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Mark Thompson
On 08/11/17 21:26, Rostislav Pehlivanov wrote: > Signed-off-by: Rostislav Pehlivanov > --- > doc/developer.texi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/developer.texi b/doc/developer.texi > index a7b4f1d737..de7d887451 100644 > ---

Re: [FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Carl Eugen Hoyos
2017-11-08 22:26 GMT+01:00 Rostislav Pehlivanov : > +@item > +for loops with variable definition (@samp{for (int i = 0; i < 8; i++)}); Don't you think that this makes the code slightly uglier? Carl Eugen ___ ffmpeg-devel mailing

[FFmpeg-devel] [PATCH] doc/developer: update style guidelines to include for loops with declarations

2017-11-08 Thread Rostislav Pehlivanov
Signed-off-by: Rostislav Pehlivanov --- doc/developer.texi | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/developer.texi b/doc/developer.texi index a7b4f1d737..de7d887451 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -132,6 +132,9 @@ designated