Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-16 Thread Gyan Doshi
On 17-07-2018 02:38 AM, Wang Cao wrote: I was thinking to output stats for each video/audio stream one line by another. It seems this would be a huge change to users who are not aware. Keeping the old file bitrate looks good to me. Can I extend this to output file bitrate for each output

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-16 Thread Wang Cao
> if theres a file with 5 video streams it doesnt make sense to summarize > teh file with the bitrate of 1 stream > Also the user has no indication of this change, the number is just different > theres nothing informing him that it is no longer the files bitrate I was thinking to output stats for

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-12 Thread Michael Niedermayer
On Thu, Jul 12, 2018 at 04:31:11PM -0700, Wang Cao wrote: > > > > I believe users will expect that "size" shows the file size, especially > > since this was done for more than a decade. > > If this is the convention, I believe it should be kept as it was. On the > other hand, I believe >

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-12 Thread Wang Cao
> > I believe users will expect that "size" shows the file size, especially > since this was done for more than a decade. If this is the convention, I believe it should be kept as it was. On the other hand, I believe "bitrate" should be calculated through stream size not the file size. On Thu,

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-12 Thread Carl Eugen Hoyos
2018-07-12 20:56 GMT+02:00, Wang Cao : > After my change: > >> frame=3 fps=0.0 q=2.0 Lsize= 51kB time=00:00:00.12 >> bitrate=3495.7kbits/s speed= 12x > > Before my change(master branch) > >> frame=3 fps=0.0 q=2.0 Lsize= 57kB time=00:00:00.12 >> bitrate=3884.7kbits/s speed=11.2x

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-12 Thread Wang Cao
Sorry I probably confused you a little bit. I was not suggesting removing anything. I tried to convince you that there is some issue with the bitrate calculation. From your original comments: > This changes the printed values > ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -qscale 2 -vframes 3 -an

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-07-12 Thread Michael Niedermayer
On Wed, Jul 11, 2018 at 03:47:45PM -0700, Wang Cao wrote: > > > > This changes the printed values > > ./ffmpeg -i ~/videos/matrixbench_mpeg2.mpg -qscale 2 -vframes 3 -an > > test2.avi > > frame=3 fps=0.0 q=2.0 Lsize= 51kB time=00:00:00.12 > > bitrate=3495.7kbits/s speed= 12x > >

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-29 Thread Michael Niedermayer
On Fri, Jun 22, 2018 at 04:03:38PM +0800, Wang Cao wrote: > Make ffmpeg to output stats for each video/audio streams and each ouptut file > ffmpeg output log in print_report. The report of video/audio sizes is clear > now as previously all output video/audio sizes were combined to report and it

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-28 Thread Wang Cao
Friendly ping. Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-22 Thread Wang Cao
Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_report. The report of video/audio sizes is clear now as previously all output video/audio sizes were combined to report and it is unclear such stats is for one output files or aggregates for

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-21 Thread Michael Niedermayer
On Fri, Jun 15, 2018 at 01:37:31PM +0800, Wang Cao wrote: > Make ffmpeg to output stats for each video/audio streams and each ouptut file > ffmpeg output log in print_report. The report of video/audio sizes is clear > now as previously all output video/audio sizes were combined to report and it

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream - Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_repor

2018-06-20 Thread Wang Cao
Thanks for letting me know about this. I actually submitted another patch without long commit message. I will clean up according to your feedback after getting feedbacks from other people. On Sat, Jun 16, 2018 at 2:52 AM Michael Niedermayer wrote: > On Thu, Jun 14, 2018 at 08:35:48PM +0800,

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-20 Thread Wang Cao
Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_report. The report of video/audio sizes is clear now as previously all output video/audio sizes were combined to report and it is unclear such stats is for one output files or aggregates for

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream - Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_repor

2018-06-15 Thread Michael Niedermayer
On Thu, Jun 14, 2018 at 08:35:48PM +0800, Wang Cao wrote: > Signed-off-by: Wang Cao > --- > fftools/ffmpeg.c | 45 +++-- > 1 file changed, 31 insertions(+), 14 deletions(-) this adds some warnings: CC fftools/ffmpeg.o fftools/ffmpeg.c:1533:13:

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-15 Thread Moritz Barsnick
On Fri, Jun 15, 2018 at 13:37:31 +0800, Wang Cao wrote: > Make ffmpeg to output stats for each video/audio streams and each > ouptut file ffmpeg output log in print_report. The report of > video/audio sizes is clear now as previously all output video/audio > sizes were combined to report and it

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-06-14 Thread Wang Cao
Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_report. The report of video/audio sizes is clear now as previously all output video/audio sizes were combined to report and it is unclear such stats is for one output files or aggregates for

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream - Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_report. T

2018-06-14 Thread Wang Cao
Signed-off-by: Wang Cao --- fftools/ffmpeg.c | 45 +++-- 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index d4ac6903cc..1eaf344552 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -1530,17

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-25 Thread Michael Niedermayer
On Tue, May 22, 2018 at 03:40:54PM -0700, Wang Cao wrote: > - Make ffmpeg to output stats for each video/audio streams and each ouptut > file ffmpeg output log in print_report. > - The report of video/audio sizes is clear as previously all output > video/audio sizes were combined to report and it

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-22 Thread Wang Cao
- Make ffmpeg to output stats for each video/audio streams and each ouptut file ffmpeg output log in print_report. - The report of video/audio sizes is clear as previously all output video/audio sizes were combined to report and it is unclear such stats is for one output files or aggregates for

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-21 Thread Michael Niedermayer
On Mon, May 21, 2018 at 02:36:28PM -0700, Wang Cao wrote: > Sorry the ticket doesn't contain alaw_2.aif as in > https://trac.ffmpeg.org/ticket/1660 the issue is reproduceable with alaw.aif from the ticket [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Many

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-21 Thread Wang Cao
Sorry the ticket doesn't contain alaw_2.aif as in https://trac.ffmpeg.org/ticket/1660 On Fri, May 18, 2018 at 8:13 PM, Michael Niedermayer wrote: > On Fri, May 18, 2018 at 04:54:25PM -0700, Wang Cao wrote: > > - Make ffmpeg to output stats for each video streams and

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-19 Thread Moritz Barsnick
On Fri, May 18, 2018 at 16:54:25 -0700, Wang Cao wrote: Apart from the functional changes: > data_size += ost->data_size; > -if ( (ost->enc_ctx->flags & (AV_CODEC_FLAG_PASS1 | > AV_CODEC_FLAG_PASS2)) > + > +if ((ost->enc_ctx->flags & (AV_CODEC_FLAG_PASS1 | >

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-18 Thread Michael Niedermayer
On Fri, May 18, 2018 at 04:54:25PM -0700, Wang Cao wrote: > - Make ffmpeg to output stats for each video streams and each ouptut file > ffmpeg output log in print_report. > - The report of video/audio sizes is clear as previously all output > video/audio sizes were combined to report and it is

[FFmpeg-devel] [PATCH] ffmpeg.c: allow ffmpeg to output stats for each video stream

2018-05-18 Thread Wang Cao
- Make ffmpeg to output stats for each video streams and each ouptut file ffmpeg output log in print_report. - The report of video/audio sizes is clear as previously all output video/audio sizes were combined to report and it is unclear such stats is for one output files or aggregates for all