On Wed, Aug 26, 2015 at 9:47 PM, Timothy Gu wrote:
> On Tue, Aug 25, 2015 at 09:25:14PM -0400, Ganesh Ajjanagadde wrote:
>> Ok. Please place the function outside of all the opt_* stuff;
>> since this is not setting options, it should not be in the middle of them.
>> Otherwise, patch LGTM.
>
> Push
On Tue, Aug 25, 2015 at 09:25:14PM -0400, Ganesh Ajjanagadde wrote:
> Ok. Please place the function outside of all the opt_* stuff;
> since this is not setting options, it should not be in the middle of them.
> Otherwise, patch LGTM.
Pushed with the changes.
Timothy
__
On Tue, Aug 25, 2015 at 9:03 PM, Timothy Gu wrote:
> On Tue, Aug 25, 2015 at 08:19:59PM -0400, Ganesh Ajjanagadde wrote:
>> For consistency, prefix with an opt_?
>
> This name is chosen to be consistent with other show_ functions. opt_*
> are exclusively used for setting some options AFAICT.
Ok.
On Tue, Aug 25, 2015 at 08:19:59PM -0400, Ganesh Ajjanagadde wrote:
> For consistency, prefix with an opt_?
This name is chosen to be consistent with other show_ functions. opt_*
are exclusively used for setting some options AFAICT.
> Maybe you could check the return value of printf?
Absolutely
On Tue, Aug 25, 2015 at 08:28:43PM -0400, Ganesh Ajjanagadde wrote:
> On Tue, Aug 25, 2015 at 8:08 PM, Timothy Gu wrote:
> >
> > cmdutils.c is shared for all ff* programs. -hwaccel is only supported in
> > ffmpeg.
>
> Why?
Because nobody has implemented it for other fftools yet.
> I don't know
On Tue, Aug 25, 2015 at 8:08 PM, Timothy Gu wrote:
> On Tue, Aug 25, 2015 at 5:06 PM Ganesh Ajjanagadde wrote:
>
>> On Tue, Aug 25, 2015 at 7:47 PM, Timothy Gu wrote:
>> > ---
>> > doc/ffmpeg.texi | 4
>> > ffmpeg_opt.c| 14 ++
>> > 2 files changed, 18 insertions(+)
>> >
>
On Tue, Aug 25, 2015 at 7:47 PM, Timothy Gu wrote:
> ---
> doc/ffmpeg.texi | 4
> ffmpeg_opt.c| 14 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 51a4ec5..e1d8562 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@
On Tue, Aug 25, 2015 at 5:06 PM Ganesh Ajjanagadde wrote:
> On Tue, Aug 25, 2015 at 7:47 PM, Timothy Gu wrote:
> > ---
> > doc/ffmpeg.texi | 4
> > ffmpeg_opt.c| 14 ++
> > 2 files changed, 18 insertions(+)
> >
> > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> > index 5
On Tue, Aug 25, 2015 at 7:47 PM, Timothy Gu wrote:
> ---
> doc/ffmpeg.texi | 4
> ffmpeg_opt.c| 14 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
> index 51a4ec5..e1d8562 100644
> --- a/doc/ffmpeg.texi
> +++ b/doc/ffmpeg.texi
> @@
---
doc/ffmpeg.texi | 4
ffmpeg_opt.c| 14 ++
2 files changed, 18 insertions(+)
diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi
index 51a4ec5..e1d8562 100644
--- a/doc/ffmpeg.texi
+++ b/doc/ffmpeg.texi
@@ -698,6 +698,10 @@ is not specified, the value of the @var{DISPLAY}
env
10 matches
Mail list logo
