Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-05 Thread Gyan Doshi
On 05-09-2018 09:52 PM, Marton Balint wrote: On Wed, 5 Sep 2018, Gyan Doshi wrote: Ping. LGTM, thanks. Pushed as 1a4a8df249426c85ba6c96ef5ab022afaaf4dc8f Thanks, Gyan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-05 Thread Marton Balint
On Wed, 5 Sep 2018, Gyan Doshi wrote: On 03-09-2018 11:03 AM, Gyan Doshi wrote: On 02-09-2018 02:57 PM, Marton Balint wrote: I don't think the guards are necessary, it might make sense for somebody to reverse the meaning of left and right keys, therefore use a negative value. v3: opti

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-05 Thread Gyan Doshi
On 03-09-2018 11:03 AM, Gyan Doshi wrote: On 02-09-2018 02:57 PM, Marton Balint wrote: I don't think the guards are necessary, it might make sense for somebody to reverse the meaning of left and right keys, therefore use a negative value. v3: option renamed; sign guard removed. Gyan P

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-02 Thread Gyan Doshi
On 02-09-2018 02:57 PM, Marton Balint wrote: Change the option name to seek_interval then, -seek alone seems a bit confusing to me because it might mean to do initial seek in the input before playing the file. Haven't changed code much, kept basic protection against invalid input (val < 0

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-02 Thread Marton Balint
On Sun, 2 Sep 2018, Gyan Doshi wrote: On 01-09-2018 10:25 PM, Marton Balint wrote: In the descriptive text write "seeking" instead of jumping. @item -nodisp Disable graphical display. @item -noborder diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 368e262123..83eef17797 100644 --- a

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-01 Thread Gyan Doshi
On 01-09-2018 10:25 PM, Marton Balint wrote: In the descriptive text write "seeking" instead of jumping. @item -nodisp Disable graphical display. @item -noborder diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 368e262123..83eef17797 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-01 Thread Marton Balint
On Sat, 1 Sep 2018, Gyan Doshi wrote: From aab52de703302d26d0bd83fb28eb1a033fa57d14 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 1 Sep 2018 11:33:17 +0530 Subject: [PATCH] ffplay: add option to allow custom jump interval At present, left and right keys are hardcoded to jump by 10 seco

[FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-01 Thread Gyan Doshi
From aab52de703302d26d0bd83fb28eb1a033fa57d14 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 1 Sep 2018 11:33:17 +0530 Subject: [PATCH] ffplay: add option to allow custom jump interval At present, left and right keys are hardcoded to jump by 10 seconds. Added option allows users to set a cu