[FFmpeg-devel] ?????? [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-03 Thread ??????
Thank you for your reminding, George. I really ignore av_freep() above. Please ignore this patch. // xufuji456 ---- ??:

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-03 Thread Nicolas George
"zhilizhao(赵志立)" (12023-03-03): > > av_freep(_files); > > av_freep(_files); > > +input_files = NULL; > > +output_files = NULL; > Until we decided to make ffmpeg cmd works as a library, > it doesn’t matter. It is worse than that: the patch completely ignores the semantic

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-03 Thread zhilizhao(赵志立)
> On Mar 3, 2023, at 14:51, xufuji456 <839789...@qq.com> wrote: > > --- > fftools/ffmpeg.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 743bc0c6b6..0ce9531235 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -569,6

[FFmpeg-devel] [PATCH] fftools/ffmpeg: reset pointer, which could be reused by Android and iOS

2023-03-02 Thread xufuji456
--- fftools/ffmpeg.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 743bc0c6b6..0ce9531235 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -569,6 +569,13 @@ static void ffmpeg_cleanup(int ret) av_freep(_files);