Wujian(Chin) (12023-01-03):
> Please review it again, thanks!!
You still treat the option differently without a good reason.
You still do not protect credentials in options.
Not acceptable.
--
Nicolas George
signature.asc
Description: PGP signature
Please review it again, thanks!!
Signed-off-by: wujian_nanjing
---
doc/fftools-common-opts.texi | 11 +
fftools/cmdutils.c | 57
fftools/cmdutils.h | 21
fftools/ffmpeg.c | 7 +++---
On Mon, Dec 26, 2022 at 01:07:51PM +, Wujian(Chin) wrote:
> The issue has been modified. Please review again, thank you!
>
> Signed-off-by: wujian_nanjing
> ---
> doc/fftools-common-opts.texi | 11 +++
> fftools/cmdutils.c | 77
> ++--
>
Wujian(Chin) (12022-12-26):
> The issue has been modified. Please review again, thank you!
>
> Signed-off-by: wujian_nanjing
> ---
> doc/fftools-common-opts.texi | 11 +++
> fftools/cmdutils.c | 77
> ++--
> fftools/cmdutils.h |
The issue has been modified. Please review again, thank you!
Signed-off-by: wujian_nanjing
---
doc/fftools-common-opts.texi | 11 +++
fftools/cmdutils.c | 77 ++--
fftools/cmdutils.h | 25 ++
fftools/ffmpeg.c
On Mon, 19 Dec 2022, "zhilizhao(赵志立)" wrote:
On Dec 19, 2022, at 21:40, Marvin Scholz wrote:
On 19 Dec 2022, at 14:37, Nicolas George wrote:
Marvin Scholz (12022-12-19):
IIUC this means the `-mask_url` option has to be the first option passed,
which seems a bit of an unfortunate
> On Dec 19, 2022, at 21:40, Marvin Scholz wrote:
>
>
> On 19 Dec 2022, at 14:37, Nicolas George wrote:
>
>> Marvin Scholz (12022-12-19):
>>> IIUC this means the `-mask_url` option has to be the first option passed,
>>> which seems a bit of an unfortunate requirement and is not documented at
Marvin Scholz (12022-12-19):
> I agree, but then the docs should probably mention that to not give a false
> sense of absolute security here. And maybe note that it might
Indeed, documentation is necessary.
> be a better option to pass the password via stdin or hide the process
> from other
Gyan Doshi (12022-12-19):
> Not the case. They are used for 'end', 'finish', retries ...etc
Insufficient vigilance before accepting these changes. But not a reason
to accept more.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
On 19 Dec 2022, at 14:37, Nicolas George wrote:
> Marvin Scholz (12022-12-19):
>> IIUC this means the `-mask_url` option has to be the first option passed,
>> which seems a bit of an unfortunate requirement and is not documented at
>> all, as far as I can see. So at least this should be
On 2022-12-19 07:00 pm, Nicolas George wrote:
Wujian(Chin) (12022-12-19):
-return;
+goto end;
We only use goto for error processing.
Not the case. They are used for 'end', 'finish', retries ...etc
Regards,
Gyan
___
ffmpeg-devel
Marvin Scholz (12022-12-19):
> IIUC this means the `-mask_url` option has to be the first option passed,
> which seems a bit of an unfortunate requirement and is not documented at
> all, as far as I can see. So at least this should be clearly documented
> to prevent users being confused why the
On 19 Dec 2022, at 14:15, Wujian(Chin) wrote:
> I have modified the issues. Please review it again. Thank you.
>
> If the protocol address contains the user name and password, The ps -ef
> command exposes plaintext.
> The -mask_url parameter option is added to replace the protocol address in
>
Wujian(Chin) (12022-12-19):
> I have modified the issues. Please review it again. Thank you.
>
> If the protocol address contains the user name and password, The ps -ef
> command exposes plaintext.
Spurious comma or capital.
> The -mask_url parameter option is added to replace the protocol
I have modified the issues. Please review it again. Thank you.
If the protocol address contains the user name and password, The ps -ef command
exposes plaintext.
The -mask_url parameter option is added to replace the protocol address in the
command line with the asterisk (*).
Because other
15 matches
Mail list logo
