Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-22 Thread Tobias Rapp
On 21.11.2017 20:01, Michael Niedermayer wrote: On Tue, Nov 21, 2017 at 02:24:23PM +0100, Tobias Rapp wrote: On 20.11.2017 22:15, Michael Niedermayer wrote: On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: Tobias Rapp (2017-11-20): Would it be OK to backport the fix into

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-21 Thread Michael Niedermayer
On Tue, Nov 21, 2017 at 02:24:23PM +0100, Tobias Rapp wrote: > On 20.11.2017 22:15, Michael Niedermayer wrote: > >On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: > >>Tobias Rapp (2017-11-20): > >>>Would it be OK to backport the fix into release/3.4? I can do the > >>>cherry-picking

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-21 Thread Tobias Rapp
On 20.11.2017 22:15, Michael Niedermayer wrote: On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: Tobias Rapp (2017-11-20): Would it be OK to backport the fix into release/3.4? I can do the cherry-picking but am unsure about the policies and what other older releases should

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-20 Thread Michael Niedermayer
On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: > Tobias Rapp (2017-11-20): > > Would it be OK to backport the fix into release/3.4? I can do the > > cherry-picking but am unsure about the policies and what other older > > releases should possibly be adapted, too. > > I do not

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-20 Thread Nicolas George
Tobias Rapp (2017-11-20): > Would it be OK to backport the fix into release/3.4? I can do the > cherry-picking but am unsure about the policies and what other older > releases should possibly be adapted, too. I do not know how backporting to releases work either, but I have of course no objection

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-19 Thread Tobias Rapp
On 19.11.2017 17:39, Nicolas George wrote: L'octidi 28 brumaire, an CCXXVI, Michael Roitzsch a écrit : Hi FFmpeg team, I was using af_pan to subtract one audio file from another. I first used an amerge filter and then configured the pan filter with a channel formula like c0=c0-c2|c1=c1-c3.

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-19 Thread Nicolas George
L'octidi 28 brumaire, an CCXXVI, Michael Roitzsch a écrit : > Hi FFmpeg team, > > I was using af_pan to subtract one audio file from another. I first used an > amerge filter and then configured the pan filter with a channel formula like > c0=c0-c2|c1=c1-c3. > > However, this does not work as

[FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

2017-11-18 Thread Michael Roitzsch
Hi FFmpeg team, I was using af_pan to subtract one audio file from another. I first used an amerge filter and then configured the pan filter with a channel formula like c0=c0-c2|c1=c1-c3. However, this does not work as expected. In debug output, I can see that channel 0 correctly uses gain