Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

Hi, On 11/27/17, Carl Eugen Hoyos wrote: > 2017-11-27 18:50 GMT+01:00 Bjorn Roche : >> Sorry for the very delayed response, Carl: >> >> On Tue, Nov 21, 2017 at 6:55 PM, Carl Eugen Hoyos >> wrote: >> >>> 2017-11-21 18:53 GMT+01:00 Bjorn Roche : >>> > Support for transparencies in animated gifs

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

Hi,, On 11/21/17, Bjorn Roche wrote: > Support for transparencies in animated gifs requires modifying both > libavcodec/gif.c and libavformat/gif.c because both the graphics > control extension (handled by libavformat/gif.c) and the raw frame data > (handled by libavcodec/gif.c) must be changed.

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

2018-01-16 19:40 GMT+01:00 Bjorn Roche : > I'm just reviewing this and noticing that the patch is stale > and no longer compiles. I am happy to update, but is > there someone to review it if I do so? This is Clément's code, he has to review your patch. In any case, please

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

Hey all, I'm just reviewing this and noticing that the patch is stale and no longer compiles. I am happy to update, but is there someone to review it if I do so? I'd love to get this patch in. Thanks, bjorn On Thu, Dec 7, 2017 at 5:56 PM, Bjorn Roche wrote: > Hey all, > >

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

Hey all, Just wondering what else is needed to get this merged? Is there anything else I can do? Thanks, bjorn On Thu, Nov 30, 2017 at 12:33 PM, Bjorn Roche wrote: > We've done a bit more testing on this and it looks good here. > > On Thu, Nov 30, 2017 at 12:26 PM, Bjorn

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

We've done a bit more testing on this and it looks good here. On Thu, Nov 30, 2017 at 12:26 PM, Bjorn Roche wrote: > > > On Mon, Nov 27, 2017 at 7:12 PM, Carl Eugen Hoyos > wrote: > >> 2017-11-28 1:07 GMT+01:00 Bjorn Roche : >> > On Mon,

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

On Mon, Nov 27, 2017 at 7:12 PM, Carl Eugen Hoyos wrote: > 2017-11-28 1:07 GMT+01:00 Bjorn Roche : > > On Mon, Nov 27, 2017 at 5:41 PM, Carl Eugen Hoyos > > wrote: > > >> >> Does remuxing animated gif with transparency work with your

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

2017-11-28 1:12 GMT+01:00 Bjorn Roche : > On Mon, Nov 27, 2017 at 5:35 PM, Carl Eugen Hoyos > wrote: > >> 2017-11-27 19:30 GMT+01:00 Bjorn Roche : >> > >> >> > The only way I can see is to move some functionality between the mixer >> and >> >

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Mon, Nov 27, 2017 at 5:35 PM, Carl Eugen Hoyos wrote: > 2017-11-27 19:30 GMT+01:00 Bjorn Roche : > > > > > The only way I can see is to move some functionality between the mixer > and > > the encoder. It's not a clear line between the codec and the

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

2017-11-28 1:07 GMT+01:00 Bjorn Roche : > On Mon, Nov 27, 2017 at 5:41 PM, Carl Eugen Hoyos > wrote: >> >> Does remuxing animated gif with transparency work with your patch? >> > >> > A command like this: >> > >> > ffmpeg -i in.gif out.gif >> > >> > seems

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

On Mon, Nov 27, 2017 at 5:41 PM, Carl Eugen Hoyos wrote: > 2017-11-27 18:50 GMT+01:00 Bjorn Roche : > > Sorry for the very delayed response, Carl: > > > > On Tue, Nov 21, 2017 at 6:55 PM, Carl Eugen Hoyos > > wrote: > > > >> 2017-11-21

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

2017-11-27 18:50 GMT+01:00 Bjorn Roche : > Sorry for the very delayed response, Carl: > > On Tue, Nov 21, 2017 at 6:55 PM, Carl Eugen Hoyos > wrote: > >> 2017-11-21 18:53 GMT+01:00 Bjorn Roche : >> > Support for transparencies in animated gifs

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

2017-11-27 19:30 GMT+01:00 Bjorn Roche : > > On Fri, Nov 3, 2017 at 8:11 PM, Carl Eugen Hoyos wrote: > >> 2017-10-24 18:40 GMT+02:00 Bjorn Roche : >> >> > - I don’t know if/how to update the FATE tests. >> >> A quick way (that needs some

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

Thanks Moritz and Carl for your help with fate. This email was stuck in my drafts :( Comments below: On Fri, Nov 3, 2017 at 8:11 PM, Carl Eugen Hoyos wrote: > 2017-10-24 18:40 GMT+02:00 Bjorn Roche : > > > - I don’t know if/how to update the FATE tests. > >

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

Sorry for the very delayed response, Carl: On Tue, Nov 21, 2017 at 6:55 PM, Carl Eugen Hoyos wrote: > 2017-11-21 18:53 GMT+01:00 Bjorn Roche : > > Support for transparencies in animated gifs requires modifying both > > libavcodec/gif.c and libavformat/gif.c

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs

2017-11-21 18:53 GMT+01:00 Bjorn Roche : > Support for transparencies in animated gifs requires modifying both > libavcodec/gif.c and libavformat/gif.c because both the graphics > control extension (handled by libavformat/gif.c) and the raw frame data > (handled by

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

2017-10-24 18:40 GMT+02:00 Bjorn Roche : > - I don’t know if/how to update the FATE tests. A quick way (that needs some double-checking) is: $ make GEN=1 SAMPLES=fate-suite fate (This overwrites all values with the new output.) Is the new side-data unavoidable? (Would the only

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Thu, Nov 02, 2017 at 11:45:20 -0400, Bjorn Roche wrote: > > - I don’t know if/how to update the FATE tests. > > Can anyone comment on this? Do I update the tests in the same patch or > separate that? Your patch is not allowed to break fate. If the fate results are correct references, then

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

> - I don’t know if/how to update the FATE tests. Can anyone comment on this? Do I update the tests in the same patch or separate that? -- Bjorn Roche Sr. Video Pipeline Engineer bj...@giphy.com ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Wed, Oct 25, 2017 at 09:51:39AM -0400, Bjorn Roche wrote: > On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer > wrote: > > > On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote: > > > Support for transparencies in animated gifs requires modifying both > > >

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Tue, Oct 24, 2017 at 8:56 PM, Michael Niedermayer wrote: > On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote: > > Support for transparencies in animated gifs requires modifying both > > libavcodec/gif.c and libavformat/gif.c because both the graphics > >

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Tue, Oct 24, 2017 at 12:40:22PM -0400, Bjorn Roche wrote: > Support for transparencies in animated gifs requires modifying both > libavcodec/gif.c and libavformat/gif.c because both the graphics > control extension (handled by libavformat/gif.c) and the raw frame data > (handled by

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

On Tue, Oct 24, 2017 at 4:24 PM, Carl Eugen Hoyos wrote: > 2017-10-24 18:40 GMT+02:00 Bjorn Roche : > > > This patch assumes paletteuse has already been patched to support > > transparency. (e.g. lavfi/paletteuse: fix to support transparency) > > Which should

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

2017-10-24 18:40 GMT+02:00 Bjorn Roche : [...] The patch adds two warnings here on compilation of gif.c, they should be fixed at some point: libavcodec/gif.c:164:5: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] uint8_t *frame_disposal

Re: [FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

2017-10-24 18:40 GMT+02:00 Bjorn Roche : > This patch assumes paletteuse has already been patched to support > transparency. (e.g. lavfi/paletteuse: fix to support transparency) Which should - imo - be unrelated to this patch and indeed, transcoding a pal8 apng (produced with

[FFmpeg-devel] [PATCH] fix for transparencies in animated gifs (requires feedback)

Support for transparencies in animated gifs requires modifying both libavcodec/gif.c and libavformat/gif.c because both the graphics control extension (handled by libavformat/gif.c) and the raw frame data (handled by libavcodec/gif.c) must be changed. This is because transparencies in GIF can be