Re: [FFmpeg-devel] [PATCH] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-07 Thread Derek Buitenhuis
On 12/7/2016 8:10 PM, Michael Niedermayer wrote: > this deadlocks on some samples > ill try to find one that i can share I have a vague idea maybe why, but I'd need a sample, yes. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmp

Re: [FFmpeg-devel] [PATCH] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-07 Thread Michael Niedermayer
On Wed, Dec 07, 2016 at 06:06:32PM +, Derek Buitenhuis wrote: > This could happen when there was a frame number gap and frame threading was > used. > > This fixes #5458. > > Debugging-by: Ronald S. Bultje > Debugging-by: Justin Ruggles > Signed-off-by: Derek Buitenhuis > --- > This fixes

Re: [FFmpeg-devel] [PATCH] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-07 Thread Derek Buitenhuis
On 12/7/2016 6:43 PM, Carl Eugen Hoyos wrote: > 2016-12-07 19:06 GMT+01:00 Derek Buitenhuis : >> This could happen when there was a frame number >> gap and frame threading was used. >> >> This fixes #5458. > > Does this patch have a speed impact on valid streams? > I ask because the sample stream

Re: [FFmpeg-devel] [PATCH] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-07 Thread Carl Eugen Hoyos
2016-12-07 19:06 GMT+01:00 Derek Buitenhuis : > This could happen when there was a frame number > gap and frame threading was used. > > This fixes #5458. Does this patch have a speed impact on valid streams? I ask because the sample stream is invalid so I thought ex falso quodlibet would apply. C

[FFmpeg-devel] [PATCH] h264_slice: Wait for refs to be available before we use them in error concealment

2016-12-07 Thread Derek Buitenhuis
This could happen when there was a frame number gap and frame threading was used. This fixes #5458. Debugging-by: Ronald S. Bultje Debugging-by: Justin Ruggles Signed-off-by: Derek Buitenhuis --- This fixes a ton of samples that had frame num gaps and were decoding using large numbers of thr