Re: [FFmpeg-devel] [PATCH] id3v2: catch avio_read errors in check_tag

2015-05-11 Thread Michael Niedermayer
On Mon, May 11, 2015 at 08:07:49PM +0200, Andreas Cadhalpun wrote: > Since len is an unsigned int, the comparison is currently treated as > unsigned and thus ignores all errors from avio_read. > > Thus cast len to int, which is unproblematic, because at that point len > is between 0 and 4. > > Th

[FFmpeg-devel] [PATCH] id3v2: catch avio_read errors in check_tag

2015-05-11 Thread Andreas Cadhalpun
Since len is an unsigned int, the comparison is currently treated as unsigned and thus ignores all errors from avio_read. Thus cast len to int, which is unproblematic, because at that point len is between 0 and 4. This fixes 'Conditional jump or move depends on uninitialised value' valgrind warni