Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On 17/03/16 13:57, Michael Niedermayer wrote: > On Thu, Mar 17, 2016 at 01:48:37PM +, Mark Thompson wrote: >> hevc_parse.c | 10 -- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> daf73b16f8185221a1e8112ab1928157a855fe76 >> 0001-lavc-hevc-Allow-arbitrary-garbage-in-bytestream

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On 17/03/16 14:11, Mark Thompson wrote: > On 17/03/16 13:57, Michael Niedermayer wrote: >> On Thu, Mar 17, 2016 at 01:48:37PM +, Mark Thompson wrote: >>> hevc_parse.c | 10 -- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> daf73b16f8185221a1e8112ab1928157a855fe76 >>> 0001-

[FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

Hi, See attached; fixes ticket #5344. Thanks, - Mark >From fbc76e59225d2a6a0609119ca682d4886874705b Mon Sep 17 00:00:00 2001 From: Mark Thompson Date: Wed, 16 Mar 2016 20:26:39 + Subject: [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On 16/03/16 23:41, Hendrik Leppkes wrote: > On Wed, Mar 16, 2016 at 9:37 PM, Mark Thompson wrote: >> --- >> libavcodec/hevc_parse.c | 14 ++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/libavcodec/hevc_parse.c b/libavcodec/hevc_parse.c >> index 63ed84a..8c629ff 100644 >> --- a

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Thu, Mar 17, 2016 at 1:21 PM, Hendrik Leppkes wrote: > On Thu, Mar 17, 2016 at 1:10 PM, Mark Thompson wrote: >>> >>> Wouldn't it be simpler then to add a condition to the existing loop to >>> only error out when no NALs exist? >> >> I apologise if I'm not understanding exactly what you mean, b

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Thu, Mar 17, 2016 at 01:48:37PM +, Mark Thompson wrote: > On 17/03/16 12:30, Hendrik Leppkes wrote: > > On Thu, Mar 17, 2016 at 1:21 PM, Hendrik Leppkes > > wrote: > >> On Thu, Mar 17, 2016 at 1:10 PM, Mark Thompson wrote: > > Wouldn't it be simpler then to add a condition to th

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Wed, Mar 16, 2016 at 9:37 PM, Mark Thompson wrote: > --- > libavcodec/hevc_parse.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavcodec/hevc_parse.c b/libavcodec/hevc_parse.c > index 63ed84a..8c629ff 100644 > --- a/libavcodec/hevc_parse.c > +++ b/libavcodec/hevc_pa

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Thu, Mar 17, 2016 at 1:10 PM, Mark Thompson wrote: >> >> Wouldn't it be simpler then to add a condition to the existing loop to >> only error out when no NALs exist? > > I apologise if I'm not understanding exactly what you mean, but wouldn't that > then accept any trailing garbage at all as lo

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Sat, Mar 19, 2016 at 10:38:15AM +0100, Hendrik Leppkes wrote: > On Sat, Mar 19, 2016 at 3:21 AM, Michael Niedermayer > wrote: > > On Sat, Mar 19, 2016 at 03:06:22AM +0100, Michael Niedermayer wrote: > >> On Thu, Mar 17, 2016 at 02:35:27PM +, Mark Thompson wrote: > >> > On 17/03/16 14:11, Ma

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Sat, Mar 19, 2016 at 3:21 AM, Michael Niedermayer wrote: > On Sat, Mar 19, 2016 at 03:06:22AM +0100, Michael Niedermayer wrote: >> On Thu, Mar 17, 2016 at 02:35:27PM +, Mark Thompson wrote: >> > On 17/03/16 14:11, Mark Thompson wrote: >> > > On 17/03/16 13:57, Michael Niedermayer wrote: >>

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Thu, Mar 17, 2016 at 12:50 AM, Mark Thompson wrote: > On 16/03/16 23:41, Hendrik Leppkes wrote: >> On Wed, Mar 16, 2016 at 9:37 PM, Mark Thompson wrote: >>> --- >>> libavcodec/hevc_parse.c | 14 ++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/libavcodec/hevc_parse.c b/l

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On 17/03/16 12:30, Hendrik Leppkes wrote: > On Thu, Mar 17, 2016 at 1:21 PM, Hendrik Leppkes wrote: >> On Thu, Mar 17, 2016 at 1:10 PM, Mark Thompson wrote: Wouldn't it be simpler then to add a condition to the existing loop to only error out when no NALs exist? >>> >>> I apologise

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On 17/03/16 07:51, Hendrik Leppkes wrote: > On Thu, Mar 17, 2016 at 12:50 AM, Mark Thompson wrote: >> On 16/03/16 23:41, Hendrik Leppkes wrote: >>> On Wed, Mar 16, 2016 at 9:37 PM, Mark Thompson wrote: --- libavcodec/hevc_parse.c | 14 ++ 1 file changed, 14 insertions(+)

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Thu, Mar 17, 2016 at 02:35:27PM +, Mark Thompson wrote: > On 17/03/16 14:11, Mark Thompson wrote: > > On 17/03/16 13:57, Michael Niedermayer wrote: > >> On Thu, Mar 17, 2016 at 01:48:37PM +, Mark Thompson wrote: > >>> hevc_parse.c | 10 -- > >>> 1 file changed, 8 insertions(+)

Re: [FFmpeg-devel] [PATCH] lavc/hevc: Allow arbitrarily many trailing_zero_8bits after a NAL unit in bytestream format.

On Sat, Mar 19, 2016 at 03:06:22AM +0100, Michael Niedermayer wrote: > On Thu, Mar 17, 2016 at 02:35:27PM +, Mark Thompson wrote: > > On 17/03/16 14:11, Mark Thompson wrote: > > > On 17/03/16 13:57, Michael Niedermayer wrote: > > >> On Thu, Mar 17, 2016 at 01:48:37PM +, Mark Thompson wrote: