Re: [FFmpeg-devel] [PATCH] lavc/libdavs2: use assert instead of wrong return value

[Carl Eugen Hoyos]

2018-11-01 5:20 GMT+01:00, hwren :
> Signed-off-by: hwren 
> ---
>  libavcodec/libdavs2.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c
> index 4dbce73..acdfaca 100644
> --- a/libavcodec/libdavs2.c
> +++ b/libavcodec/libdavs2.c
> @@ -93,7 +93,7 @@ static int davs2_dump_frames(AVCodecContext *avctx,
> davs2_picture_t *pic,
>  break;
>  default:
>  av_log(avctx, AV_LOG_ERROR, "Decoder error: unknown frame
> type\n");
> -return AVERROR_EXTERNAL;
> +assert(0);

Please do not assert on return values of an external library.

Carl Eugen
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavc/libdavs2: use assert instead of wrong return value

[hwren]

Signed-off-by: hwren 
---
 libavcodec/libdavs2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/libdavs2.c b/libavcodec/libdavs2.c
index 4dbce73..acdfaca 100644
--- a/libavcodec/libdavs2.c
+++ b/libavcodec/libdavs2.c
@@ -93,7 +93,7 @@ static int davs2_dump_frames(AVCodecContext *avctx, 
davs2_picture_t *pic,
 break;
 default:
 av_log(avctx, AV_LOG_ERROR, "Decoder error: unknown frame type\n");
-return AVERROR_EXTERNAL;
+assert(0);
 }
 
 for (plane = 0; plane < 3; ++plane) {
-- 
2.7.4

___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel