Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: set BRCParamMultiplier to aviod BRC overflow

2019-01-11 Thread 李忠
Good catch.Yes,that is possible but possibility is smaller than bitrate since they are in Bytes. I got it too but finally ignored them to make things simple. Let me send an update version soon. Carl Eugen Hoyos 于 2019年1月11日周五 下午9:45写道: > 2019-01-11 14:25 GMT+01:00, Hendrik Leppkes : > > On Fri,

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: set BRCParamMultiplier to aviod BRC overflow

2019-01-11 Thread Carl Eugen Hoyos
2019-01-11 14:25 GMT+01:00, Hendrik Leppkes : > On Fri, Jan 11, 2019 at 1:18 PM Carl Eugen Hoyos wrote: >> >> 2019-01-11 13:09 GMT+01:00, Zhong Li : >> > +//libmfx BRC parameters are 16 bits thus maybe overflow, then >> > BRCParamMultiplier is needed >> > +target_bitrate_kbps = avctx->bit_

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: set BRCParamMultiplier to aviod BRC overflow

2019-01-11 Thread Hendrik Leppkes
On Fri, Jan 11, 2019 at 1:18 PM Carl Eugen Hoyos wrote: > > 2019-01-11 13:09 GMT+01:00, Zhong Li : > > +//libmfx BRC parameters are 16 bits thus maybe overflow, then > > BRCParamMultiplier is needed > > +target_bitrate_kbps = avctx->bit_rate / 1000; > > +max_bitrate_kbps = avctx->rc_ma

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: set BRCParamMultiplier to aviod BRC overflow

2019-01-11 Thread Carl Eugen Hoyos
2019-01-11 13:09 GMT+01:00, Zhong Li : > +//libmfx BRC parameters are 16 bits thus maybe overflow, then > BRCParamMultiplier is needed > +target_bitrate_kbps = avctx->bit_rate / 1000; > +max_bitrate_kbps = avctx->rc_max_rate / 1000; > +brc_param_multiplier = (FFMAX(target_bitrate_kb

[FFmpeg-devel] [PATCH] lavc/qsvenc: set BRCParamMultiplier to aviod BRC overflow

2019-01-11 Thread Zhong Li
Fix ticket #7663 Signed-off-by: Zhong Li --- libavcodec/qsvenc.c | 37 +++-- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index e3b5a72..0e8229e 100644 --- a/libavcodec/qsvenc.c +++ b/libavcodec/qsvenc.c