Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

2016-10-24 Thread wm4
On Mon, 24 Oct 2016 12:18:07 -0700 Aman Gupta wrote: > On Sun, Oct 23, 2016 at 11:20 PM, Aman Gupta wrote: > > > > > > > On Sunday, October 23, 2016, Richard Kern wrote: > > > >> > >> > On Oct 19, 2016, at 8:45 PM, Aman Gupta wrote: > >> > > >> > From: Aman Gupta > >> > > >> > ff_videoto

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

2016-10-24 Thread Aman Gupta
On Sun, Oct 23, 2016 at 11:20 PM, Aman Gupta wrote: > > > On Sunday, October 23, 2016, Richard Kern wrote: > >> >> > On Oct 19, 2016, at 8:45 PM, Aman Gupta wrote: >> > >> > From: Aman Gupta >> > >> > ff_videotoolbox_avcc_extradata_create() was never being called if >> > avctx->extradata_size=

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

2016-10-24 Thread Aman Gupta
On Sunday, October 23, 2016, Richard Kern wrote: > > > On Oct 19, 2016, at 8:45 PM, Aman Gupta > > wrote: > > > > From: Aman Gupta > > > > > ff_videotoolbox_avcc_extradata_create() was never being called if > > avctx->extradata_size==0, even though the function does not need or use > > the avctx-

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

2016-10-23 Thread Richard Kern
> On Oct 19, 2016, at 8:45 PM, Aman Gupta wrote: > > From: Aman Gupta > > ff_videotoolbox_avcc_extradata_create() was never being called if > avctx->extradata_size==0, even though the function does not need or use > the avctx->extradata. Could this be a bug in another part of the code? It see

[FFmpeg-devel] [PATCH] lavc/videotoolbox: fix avcc creation for h264 streams missing extradata

2016-10-19 Thread Aman Gupta
From: Aman Gupta ff_videotoolbox_avcc_extradata_create() was never being called if avctx->extradata_size==0, even though the function does not need or use the avctx->extradata. This manifested itself only on h264 streams in specific containers, and only on iOS. I guess the macOS version of Video