Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 8:21 PM, Michael Bradshaw < mjbshaw-at-google@ffmpeg.org> wrote: > > Updated patch attached (which contains James Almer's suggestion for the > -DOPJ_STATIC fix; thanks, James!). Patch pushed. Thanks, all. Please let me know if anyone hits any snags due to this.

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Thu, Oct 19, 2017 at 2:28 AM, Moritz Barsnick wrote: > On Wed, Oct 18, 2017 at 20:21:21 -0700, Michael Bradshaw wrote: > > I've added a note to the Changelog. Let me know if there are additional > > notices that should be made. > > It was remarked that pkg-config support was

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 20:21:21 -0700, Michael Bradshaw wrote: > I've added a note to the Changelog. Let me know if there are additional > notices that should be made. It was remarked that pkg-config support was introduced with *2.0.1*, not *2.1(.0)*. James's comment:

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 5:04 PM, Michael Niedermayer wrote: > > i think the patch should add some note to the release notes or > changelog > I've added a note to the Changelog. Let me know if there are additional notices that should be made. Updated patch attached

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 6:49 PM, Ricardo Constantino wrote: There's a few other libs that require static-only Cflags (libxml2, at least), so openjpeg shouldn't be different. pkgconf does support Cflags.private, but no one uses it. To be fair, I did submit a pull request¹ to twolame that would have

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 01:46:59PM -0700, Michael Bradshaw wrote: > On Wed, Oct 18, 2017 at 1:26 PM, Michael Niedermayer > wrote: > > > > correction, xenial and zesty have 2.1.* under the name libopenjp2-7 > > > > trusty does not though > > > Yeah, Ubuntu 14.04 is stuck

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 19 October 2017 at 00:14, James Almer wrote: > On 10/18/2017 7:49 PM, Ricardo Constantino wrote: > > > There's a few other libs that require static-only Cflags (libxml2, at > > least), so openjpeg shouldn't be different. pkgconf does support > > Cflags.private, but no one

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 7:49 PM, Ricardo Constantino wrote: > On 18 October 2017 at 23:22, James Almer wrote: > >> On 10/18/2017 6:56 PM, Michael Bradshaw wrote: >>> -DOPJ_STATIC was originally added to ffmpeg's configure script for >> Windows. >>> Unconditionally adding -DOPJ_STATIC

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 7:49 PM, Reino Wijnsma wrote: > On 19-10-2017 0:22, James Almer wrote: >> It think the following should be enough: >>> enabled libopenjpeg && { use_pkg_config libopenjpeg "libopenjp2 >= >>> 2.1.0" openjpeg.h opj_version || >>>

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 18 October 2017 at 23:22, James Almer wrote: > On 10/18/2017 6:56 PM, Michael Bradshaw wrote: > > -DOPJ_STATIC was originally added to ffmpeg's configure script for > Windows. > > Unconditionally adding -DOPJ_STATIC would conflict with people who are > > dynamically

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 19-10-2017 0:22, James Almer wrote: > It think the following should be enough: >> enabled libopenjpeg && { use_pkg_config libopenjpeg "libopenjp2 >= >> 2.1.0" openjpeg.h opj_version || >>{ require_pkg_config libopenjpeg "libopenjp2 >>

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 6:56 PM, Michael Bradshaw wrote: > -DOPJ_STATIC was originally added to ffmpeg's configure script for Windows. > Unconditionally adding -DOPJ_STATIC would conflict with people who are > dynamically linking. I'll look into this further. I'll start with the > following: > > enabled

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 2:44 PM, Reino Wijnsma wrote: > > Is there a reason you left out -DOPJ_STATIC? > I assumed OpenJPEG's pkgconfig file would be smart enough to add it in if needed. Apparently that's not the case. Dang.

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 18-10-2017 21:46, Michael Bradshaw wrote: > From fb8334d0cecc889ebce3af968c56a3afbd2f6047 Mon Sep 17 00:00:00 2001 > From: Michael Bradshaw > Date: Wed, 18 Oct 2017 11:34:06 -0700 > Subject: [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 5:46 PM, Michael Bradshaw wrote: > On Wed, Oct 18, 2017 at 1:26 PM, Michael Niedermayer > wrote: >> >> correction, xenial and zesty have 2.1.* under the name libopenjp2-7 >> >> trusty does not though > > > Yeah, Ubuntu 14.04 is stuck on the ancient OpenJPEG

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 1:26 PM, Michael Niedermayer wrote: > > correction, xenial and zesty have 2.1.* under the name libopenjp2-7 > > trusty does not though Yeah, Ubuntu 14.04 is stuck on the ancient OpenJPEG 1.3. I think it's fine to proceed with this patch since:

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 10:22:13PM +0200, Michael Niedermayer wrote: > On Wed, Oct 18, 2017 at 12:46:13PM -0700, Michael Bradshaw wrote: > > Thanks for the review! > > > > On Wed, Oct 18, 2017 at 12:26 PM, James Almer wrote: > > > > > > Add a line to Changelog about dropping

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On Wed, Oct 18, 2017 at 12:46:13PM -0700, Michael Bradshaw wrote: > Thanks for the review! > > On Wed, Oct 18, 2017 at 12:26 PM, James Almer wrote: > > > > Add a line to Changelog about dropping support for OpenJPEG <= 2.0. > > > > Done. > > > +enabled libopenjpeg &&

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Thanks for the review! On Wed, Oct 18, 2017 at 12:26 PM, James Almer wrote: > > Add a line to Changelog about dropping support for OpenJPEG <= 2.0. > Done. > +enabled libopenjpeg && require_pkg_config libopenjpeg libopenjp2 > openjpeg.h opj_version > > OpenJPEG 2.0.1

Re: [FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

On 10/18/2017 3:43 PM, Michael Bradshaw wrote: > Hi, > > Attached patch drops support for OpenJPEG 1.3, 1.4, 1.5, and 2.0. After > this patch, only versions 2.1 and above will be supported (and will require > pkg-config). > > Tested locally on macOS with OpenJPEG 2.3 by both encoding and

[FFmpeg-devel] [PATCH] lavc: drop support for OpenJPEG 1.3-2.0

Hi, Attached patch drops support for OpenJPEG 1.3, 1.4, 1.5, and 2.0. After this patch, only versions 2.1 and above will be supported (and will require pkg-config). Tested locally on macOS with OpenJPEG 2.3 by both encoding and decoding a jp2 file. Please review. Thanks, --Michael