Re: [FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-10 Thread Carl Eugen Hoyos
2018-11-08 8:25 GMT+01:00, Jan Ekström : > When looking into something that is specified, wouldn't you go > through it and enable what it mentions if you notice that there > were actually more things than you originally thought?! This may be acceptable for "DTS4" or similar but in general, it is

Re: [FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-07 Thread Jan Ekström
On Thu, Nov 8, 2018, 03:38 Carl Eugen Hoyos > Apart from "please see archives": > Why can't we do it like the last decade and fix files that don't work > instead of creating patches that apparently are impossible to test? > > Carl Eugen > We have something that: a) has a specification (albeit by

Re: [FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-07 Thread Carl Eugen Hoyos
2018-11-07 23:41 GMT+01:00, Jan Ekström : > On Tue, Nov 6, 2018 at 11:56 PM Carl Eugen Hoyos wrote: >> >> Since the patch doesn't change default muxing behaviour, it could >> be committed for the time being, please mention ticket #7347. >> Maybe print a warning if not reading the additional

Re: [FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-07 Thread Jan Ekström
On Tue, Nov 6, 2018 at 11:56 PM Carl Eugen Hoyos wrote: > > Since the patch doesn't change default muxing behaviour, it could > be committed for the time being, please mention ticket #7347. > Maybe print a warning if not reading the additional information > can be an issue. > > Carl Eugen I will

Re: [FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-06 Thread Carl Eugen Hoyos
2018-11-05 18:26 GMT+01:00, Jan Ekström : > On Mon, Nov 5, 2018 at 6:34 PM Rodger Combs wrote: >> >> This refers to "Dolby Vision", which can have some additional extensions, >> but (usually?) is also valid HEVC. > > This probably will have to be referenced against >

Re: [FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-05 Thread Jan Ekström
On Mon, Nov 5, 2018 at 6:34 PM Rodger Combs wrote: > > This refers to "Dolby Vision", which can have some additional extensions, > but (usually?) is also valid HEVC. This probably will have to be referenced against

[FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-05 Thread Rodger Combs
This refers to "Dolby Vision", which can have some additional extensions, but (usually?) is also valid HEVC. --- libavformat/isom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index ca9d22e4f7..fbfa0dc057 100644 --- a/libavformat/isom.c +++