Pls find attached, the corrected patch.
On Wed, Aug 8, 2018 at 5:24 PM Sasi Inguva wrote:
> Ok. i'll correct the commit message.
>
> On Wed, Aug 8, 2018 at 4:25 PM Michael Niedermayer
> wrote:
>
>> On Wed, Aug 08, 2018 at 12:20:34PM -0700, Sasi Inguva wrote:
>> > i intended it only for audio,
Ok. i'll correct the commit message.
On Wed, Aug 8, 2018 at 4:25 PM Michael Niedermayer
wrote:
> On Wed, Aug 08, 2018 at 12:20:34PM -0700, Sasi Inguva wrote:
> > i intended it only for audio, but i don't see any harm if it gets applied
> > to subtitle tracks also .
>
> if you want subs incldued
On Wed, Aug 08, 2018 at 12:20:34PM -0700, Sasi Inguva wrote:
> i intended it only for audio, but i don't see any harm if it gets applied
> to subtitle tracks also .
if you want subs incldued then the commit message is wrong at least
if you dont want subs incldued the change is wrong
[...]
--
i intended it only for audio, but i don't see any harm if it gets applied
to subtitle tracks also .
On Tue, Aug 7, 2018 at 3:23 PM Michael Niedermayer
wrote:
> On Mon, Aug 06, 2018 at 04:32:29PM -0700, isasi-at-google@ffmpeg.org
> wrote:
> > From: Sasi Inguva
> >
> > Fixes vorbis mp4 audio
On Mon, Aug 06, 2018 at 04:32:29PM -0700, isasi-at-google@ffmpeg.org wrote:
> From: Sasi Inguva
>
> Fixes vorbis mp4 audio files, with edit list specified. Since
> st->skip_samples is not set in case of vorbis , ffmpeg computes the
> start_time as negative.
>
> Signed-off-by: Sasi Inguva
>
Attaching the fate file.
On Mon, Aug 6, 2018 at 4:33 PM wrote:
> From: Sasi Inguva
>
> Fixes vorbis mp4 audio files, with edit list specified. Since
> st->skip_samples is not set in case of vorbis , ffmpeg computes the
> start_time as negative.
>
> Signed-off-by: Sasi Inguva
> ---
>
From: Sasi Inguva
Fixes vorbis mp4 audio files, with edit list specified. Since
st->skip_samples is not set in case of vorbis , ffmpeg computes the
start_time as negative.
Signed-off-by: Sasi Inguva
---
libavformat/mov.c | 4 ++--
tests/fate/mov.mak
