Re: [FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-09 Thread Derek Buitenhuis
On 3/9/2018 2:42 AM, Rodger Combs wrote: > Muxing DASH may involve calling mov_write_eac3_tag multiple times on the same > stream. If we destroy eac3_priv after the first call, we don't have it > later, so we end up not writing that data. This is fine for lavf (since > everything in that atom

Re: [FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-08 Thread Rodger Combs
Muxing DASH may involve calling mov_write_eac3_tag multiple times on the same stream. If we destroy eac3_priv after the first call, we don't have it later, so we end up not writing that data. This is fine for lavf (since everything in that atom is redundant), but some other players require it.

Re: [FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-08 Thread Derek Buitenhuis
On 3/8/2018 5:10 AM, Rodger Combs wrote: > --- > libavformat/movenc.c | 1 - > 1 file changed, 1 deletion(-) Er, how/why? No info is provided in this commit message. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] lavf/movenc: keep eac3_priv around; fixes eac3 in DASH

2018-03-07 Thread Rodger Combs
--- libavformat/movenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 5b1e66c897..fb8462ed9a 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -554,7 +554,6 @@ static int mov_write_eac3_tag(AVIOContext *pb, MOVTrack *track)