Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-09 Thread Michael Niedermayer
On Wed, Aug 09, 2017 at 10:41:27PM +0100, Derek Buitenhuis wrote: > On 8/9/2017 1:00 AM, Sasi Inguva wrote: > > According to > > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > > >

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-09 Thread Derek Buitenhuis
On 8/9/2017 1:00 AM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c

[FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-08 Thread Sasi Inguva
According to https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 Signed-off-by: Sasi Inguva --- libavformat/movenc.c| 22 +++---

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-08 Thread Carl Eugen Hoyos
Hi! > Am 08.08.2017 um 22:55 schrieb Sasi Inguva : > > Ping! Please send a patch without the cosmetic changes to allow reviewing. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-08 Thread Sasi Inguva
Ping! On Aug 5, 2017 10:08 AM, "Sasi Inguva" wrote: > To the best of my knowledge, all fate changes are benign. All of them > correspond to a size increase of 54 bytes, which is the total size of the > new atoms added. > > On Sat, Aug 5, 2017 at 9:27 AM, Derek Buitenhuis < >

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-05 Thread Sasi Inguva
To the best of my knowledge, all fate changes are benign. All of them correspond to a size increase of 54 bytes, which is the total size of the new atoms added. On Sat, Aug 5, 2017 at 9:27 AM, Derek Buitenhuis wrote: > On 8/4/2017 9:35 PM, Sasi Inguva wrote: > >

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-05 Thread Derek Buitenhuis
On 8/5/2017 5:27 PM, Derek Buitenhuis wrote: > Probably OK, if FATE changes have been confirmed to be benign. Woops, replied to the wrong patch version. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-05 Thread Derek Buitenhuis
On 8/4/2017 9:35 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-05 Thread Derek Buitenhuis
On 8/4/2017 7:46 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 >

[FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-04 Thread Sasi Inguva
According to https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 Signed-off-by: Sasi Inguva --- libavformat/movenc.c| 70 +

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-04 Thread Derek Buitenhuis
On 8/4/2017 8:50 PM, Sasi Inguva wrote: > [...] Thanks for the reference, please add the section numbers alongside the QTFF doc in the commit message. > This patch sets the sgpd and sbgp atoms irrespective of whether it's > fragmented or not. So the byte addresses for some atoms will change for

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-04 Thread Sasi Inguva
From ISO-IEC-14496-12 *10 Sample Groups* *10.1 Random Access Recovery Points* *10.1.1.1* *Definition* *class AudioRollRecoveryEntry() extends AudioSampleGroupEntry (’roll’)* *{* *signed int(16) roll_distance;* *}* *An AudioRollRecoveryEntry documents the pre‐roll distance required in audio

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-04 Thread Derek Buitenhuis
On 8/4/2017 7:46 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 >

[FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

2017-08-04 Thread Sasi Inguva
According to https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html Signed-off-by: Sasi Inguva --- libavformat/movenc.c| 70 + tests/ref/fate/adtstoasc_ticket3715 | 4 +--